Add a mode to ensure a server is not already running.

Add a mode to ensure a server is not already running.

BUG=128770
TEST=local positive, negative, and no argument.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137990

[Peter Mayo, 2012-05-18 19:57:04]

This needs to precede the tool area using it.

[cmp, 2012-05-18 20:05:24]

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
File tools/xdisplaycheck/xdisplaycheck.cc (right):

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
tools/xdisplaycheck/xdisplaycheck.cc:39: if (argv[1] && strcmp(argv[1],
"--noserver")==0) {
spaces around ==

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
tools/xdisplaycheck/xdisplaycheck.cc:45: // Use upside down logic to resemble
previous behaviour.
can you change this comment to be more explicit about the case you're returning
on?  (for example 'previous behavior' won't be clear later to others looking at
the code, 'upside down logic' is not clear to me.)

[Peter Mayo, 2012-05-18 20:25:44]

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
File tools/xdisplaycheck/xdisplaycheck.cc (right):

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
tools/xdisplaycheck/xdisplaycheck.cc:39: if (argv[1] && strcmp(argv[1],
"--noserver")==0) {
On 2012/05/18 20:05:24, cmp wrote:
> spaces around ==

Done.

http://codereview.chromium.org/10409035/diff/3001/tools/xdisplaycheck/xdispla...
tools/xdisplaycheck/xdisplaycheck.cc:45: // Use upside down logic to resemble
previous behaviour.
Better?

[sadrul, 2012-05-18 20:43:07]

On 2012/05/18 20:42:28, sadrul wrote:

LGTM

[cmp, 2012-05-18 21:25:08]

lgtm

[commit-bot: I haz the power, 2012-05-18 21:29:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/10409035/7001

[commit-bot: I haz the power, 2012-05-19 00:14:38]

Change committed as 137990