Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10408089: Update RenderViewTest::LoadHTML documentation, and remove spurious commits. (Closed)

Created:
8 years, 7 months ago by gavinp
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, dhollowa+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dyu1, brettw-cc_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Update LoadHTML documentation, and remove spurious commits. All these calls to ProcessPendingMessages() after LoadHTML() were redundant, since LoadHTML directly forces a commit. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138895

Patch Set 1 #

Total comments: 2

Patch Set 2 : remediate to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/renderer/autofill/autofill_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/translate_helper_browsertest.cc View 1 7 chunks +0 lines, -7 lines 0 comments Download
M content/test/render_view_test.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gavinp
jam, These changes were in my index after my last RenderViewTest work. WDYT?
8 years, 7 months ago (2012-05-24 14:27:37 UTC) #1
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/10408089/diff/1/content/test/render_view_test.h File content/test/render_view_test.h (right): https://chromiumcodereview.appspot.com/10408089/diff/1/content/test/render_view_test.h#newcode74 content/test/render_view_test.h:74: // Loads the given HTML into the main frame ...
8 years, 7 months ago (2012-05-24 14:36:02 UTC) #2
jam
lgtm from my pov, Jochen's comment suggestion also sounds good
8 years, 7 months ago (2012-05-24 16:25:33 UTC) #3
gavinp
jochen, WDYT? http://codereview.chromium.org/10408089/diff/1/content/test/render_view_test.h File content/test/render_view_test.h (right): http://codereview.chromium.org/10408089/diff/1/content/test/render_view_test.h#newcode74 content/test/render_view_test.h:74: // Loads the given HTML into the ...
8 years, 7 months ago (2012-05-24 18:12:25 UTC) #4
jochen (gone - plz use gerrit)
lgtm, thanks
8 years, 7 months ago (2012-05-24 18:25:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10408089/13002
8 years, 7 months ago (2012-05-24 18:29:18 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-24 21:28:59 UTC) #7
Change committed as 138895

Powered by Google App Engine
This is Rietveld 408576698