chrome/renderer/translate_helper_browsertest.cc - Issue 10408089: Update RenderViewTest::LoadHTML documentation, and remove spurious commits.

Unified Diff: chrome/renderer/translate_helper_browsertest.cc

Issue 10408089: Update RenderViewTest::LoadHTML documentation, and remove spurious commits. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remediate to review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/translate_helper_browsertest.cc

diff --git a/chrome/renderer/translate_helper_browsertest.cc b/chrome/renderer/translate_helper_browsertest.cc

index 522f6242d4481f943312ee44caf206edaff85ead..8b9d1914728dca69305b96910445c58dd1788b74 100644

--- a/chrome/renderer/translate_helper_browsertest.cc

+++ b/chrome/renderer/translate_helper_browsertest.cc

@@ -311,7 +311,6 @@ TEST_F(ChromeRenderViewTest, TranslatablePage) {

SendContentStateImmediately();

LoadHTML("<html><body>A random page with random content.</body></html>");

- ProcessPendingMessages();

const IPC::Message* message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -323,7 +322,6 @@ TEST_F(ChromeRenderViewTest, TranslatablePage) {

// Now the page specifies the META tag to prevent translation.

LoadHTML("<html><head><meta name=\"google\" value=\"notranslate\"></head>"

"<body>A random page with random content.</body></html>");

- ProcessPendingMessages();

message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -334,7 +332,6 @@ TEST_F(ChromeRenderViewTest, TranslatablePage) {

// Try the alternate version of the META tag (content instead of value).

LoadHTML("<html><head><meta name=\"google\" content=\"notranslate\"></head>"

"<body>A random page with random content.</body></html>");

- ProcessPendingMessages();

message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -351,7 +348,6 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTag) {

LoadHTML("<html><head><meta http-equiv=\"content-language\" content=\"es\">"

"</head><body>A random page with random content.</body></html>");

- ProcessPendingMessages();

const IPC::Message* message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -364,7 +360,6 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTag) {

LoadHTML("<html><head><meta http-equiv=\"content-language\" "

"content=\" fr , es,en \">"

"</head><body>A random page with random content.</body></html>");

- ProcessPendingMessages();

message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -377,7 +372,6 @@ TEST_F(ChromeRenderViewTest, BackToTranslatablePage) {

SendContentStateImmediately();

LoadHTML("<html><head><meta http-equiv=\"content-language\" content=\"zh\">"

"</head><body>This page is in Chinese.</body></html>");

- ProcessPendingMessages();

const IPC::Message* message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

@@ -388,7 +382,6 @@ TEST_F(ChromeRenderViewTest, BackToTranslatablePage) {

LoadHTML("<html><head><meta http-equiv=\"content-language\" content=\"fr\">"

"</head><body>This page is in French.</body></html>");

- ProcessPendingMessages();

message = render_thread_->sink().GetUniqueMessageMatching(

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

« no previous file with comments | « chrome/renderer/autofill/autofill_browsertest.cc ('k') | content/test/render_view_test.h » ('j') | no next file with comments »