Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 10408076: Merge 138322 - Implement Mac pref-pane UI mockups (Closed)

Created:
8 years, 7 months ago by Lambros
Modified:
8 years, 7 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Merge 138322 - Implement Mac pref-pane UI mockups This updates the screens to match the mockups. There are two new nib files. One is a view with just a disable button. The other is a view with the PIN-confirmation controls. The main nib has been updated to remove all controls except for the Status text and the padlock. A new placeholder box has been added in the middle of the window, which can show either of the new nibs, depending on whether a new config has been received by the pref-pane. This also fixes some small issues: PIN is reset whenever a new config is sent to the pref-pane - this prevents the previous PIN dots being shown if the user changes PIN a second time without closing the System Preferences applet. The PIN entry box is disabled until the pane is unlocked, for a slightly improved UX. BUG=128813, 129032 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10411032 TBR=lambroslambrou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -352 lines) Patch
M remoting/host/me2me_preference_pane.h View 2 chunks +10 lines, -7 lines 0 comments Download
M remoting/host/me2me_preference_pane.mm View 6 chunks +35 lines, -17 lines 0 comments Download
M remoting/host/me2me_preference_pane.xib View 23 chunks +306 lines, -334 lines 0 comments Download
A + remoting/host/me2me_preference_pane_confirm_pin.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/me2me_preference_pane_confirm_pin.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/me2me_preference_pane_confirm_pin.xib View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/me2me_preference_pane_disable.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/me2me_preference_pane_disable.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/me2me_preference_pane_disable.xib View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lambros
8 years, 7 months ago (2012-05-22 22:33:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698