Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 10411032: Implement Mac pref-pane UI mockups (Closed)

Created:
8 years, 7 months ago by Lambros
Modified:
8 years, 7 months ago
Reviewers:
Jamie, dcaiafa
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Implement Mac pref-pane UI mockups This updates the screens to match the mockups. There are two new nib files. One is a view with just a disable button. The other is a view with the PIN-confirmation controls. The main nib has been updated to remove all controls except for the Status text and the padlock. A new placeholder box has been added in the middle of the window, which can show either of the new nibs, depending on whether a new config has been received by the pref-pane. This also fixes some small issues: PIN is reset whenever a new config is sent to the pref-pane - this prevents the previous PIN dots being shown if the user changes PIN a second time without closing the System Preferences applet. The PIN entry box is disabled until the pane is unlocked, for a slightly improved UX. BUG=128813, 129032 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138322

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix license header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1476 lines, -1362 lines) Patch
M remoting/host/me2me_preference_pane.h View 2 chunks +10 lines, -7 lines 0 comments Download
M remoting/host/me2me_preference_pane.mm View 1 6 chunks +35 lines, -17 lines 0 comments Download
M remoting/host/me2me_preference_pane.xib View 24 chunks +306 lines, -334 lines 0 comments Download
A remoting/host/me2me_preference_pane_confirm_pin.h View 1 chunk +26 lines, -0 lines 0 comments Download
A remoting/host/me2me_preference_pane_confirm_pin.mm View 1 chunk +44 lines, -0 lines 0 comments Download
A + remoting/host/me2me_preference_pane_confirm_pin.xib View 22 chunks +595 lines, -475 lines 0 comments Download
A remoting/host/me2me_preference_pane_disable.h View 1 chunk +20 lines, -0 lines 0 comments Download
A remoting/host/me2me_preference_pane_disable.mm View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + remoting/host/me2me_preference_pane_disable.xib View 19 chunks +404 lines, -529 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
8 years, 7 months ago (2012-05-18 22:57:13 UTC) #1
Lambros
I have no idea what's going on with Rietveld and the new nibs. They are ...
8 years, 7 months ago (2012-05-18 23:05:00 UTC) #2
dcaiafa
http://codereview.chromium.org/10411032/diff/1/remoting/host/me2me_preference_pane.mm File remoting/host/me2me_preference_pane.mm (right): http://codereview.chromium.org/10411032/diff/1/remoting/host/me2me_preference_pane.mm#newcode157 remoting/host/me2me_preference_pane.mm:157: confirm_pin_view_ = [[Me2MePreferencePaneConfirmPin alloc] init]; Leak in non-GC environment. ...
8 years, 7 months ago (2012-05-21 15:45:30 UTC) #3
Jamie
8 years, 7 months ago (2012-05-22 17:01:00 UTC) #4
LGTM, but Daniel's GC comment is worth fixing in a follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698