Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: dart/lib/compiler/implementation/ssa/builder.dart

Issue 10408059: Move registering to the enqueuer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/ssa/builder.dart
diff --git a/dart/lib/compiler/implementation/ssa/builder.dart b/dart/lib/compiler/implementation/ssa/builder.dart
index 8744e9ebfddab8a9dada5d73a246f0d57f3d0ff1..03223da66c72c5623bb8e70dde3e60fec7b9bdc3 100644
--- a/dart/lib/compiler/implementation/ssa/builder.dart
+++ b/dart/lib/compiler/implementation/ssa/builder.dart
@@ -1487,8 +1487,10 @@ class SsaBuilder implements Visitor {
ClassElement closureClassElement =
nestedClosureData.closureClassElement;
FunctionElement callElement = nestedClosureData.callElement;
+ // TODO(ahe): This should be registered in codegen, not here.
compiler.enqueuer.codegen.addToWorkList(callElement, elements);
- compiler.registerInstantiatedClass(closureClassElement);
+ // TODO(ahe): This should be registered in codegen, not here.
+ compiler.enqueuer.codegen.registerInstantiatedClass(closureClassElement);
assert(closureClassElement.members.isEmpty());
List<HInstruction> capturedVariables = <HInstruction>[];
@@ -1828,7 +1830,8 @@ class SsaBuilder implements Visitor {
generateInstanceGetterWithCompiledReceiver(send, receiver);
} else if (Elements.isStaticOrTopLevelFunction(element)) {
push(new HStatic(element));
- compiler.registerGetOfStaticFunction(element);
+ // TODO(ahe): This should be registered in codegen.
+ compiler.enqueuer.codegen.registerGetOfStaticFunction(element);
} else {
stack.add(localsHandler.readLocal(element));
}

Powered by Google App Engine
This is Rietveld 408576698