Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: dart/lib/compiler/implementation/native_handler.dart

Issue 10408059: Move registering to the enqueuer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/enqueue.dart ('k') | dart/lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/native_handler.dart
diff --git a/dart/lib/compiler/implementation/native_handler.dart b/dart/lib/compiler/implementation/native_handler.dart
index d6b9add71ec5c733a8d7e2fbf6e20017bd60d38b..7da59ad4d1794c498b4eb1d7d33569d77b86a77e 100644
--- a/dart/lib/compiler/implementation/native_handler.dart
+++ b/dart/lib/compiler/implementation/native_handler.dart
@@ -59,14 +59,17 @@ void processNativeClassesInLibrary(CodeEmitterTask emitter,
}
}
if (hasNativeClass) {
- compiler.registerStaticUse(compiler.findHelper(
- const SourceString('dynamicFunction')));
- compiler.registerStaticUse(compiler.findHelper(
- const SourceString('dynamicSetMetadata')));
- compiler.registerStaticUse(compiler.findHelper(
- const SourceString('defineProperty')));
- compiler.registerStaticUse(compiler.findHelper(
- const SourceString('toStringForNativeObject')));
+ final worlds = [compiler.enqueuer.resolution, compiler.enqueuer.codegen];
ngeoffray 2012/05/23 11:48:59 Could 'worlds' be placed in compiler instead?
ahe 2012/05/23 12:00:30 I'm not really sure about this yet.
+ for (Universe world in worlds) {
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('dynamicFunction')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('dynamicSetMetadata')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('defineProperty')));
+ world.registerStaticUse(compiler.findHelper(
+ const SourceString('toStringForNativeObject')));
+ }
}
}
« no previous file with comments | « dart/lib/compiler/implementation/enqueue.dart ('k') | dart/lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698