Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 10408040: Add Malay to the "Languages and Input" configuration screen (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
Reviewers:
csilv, Nikita (slow), zel
CC:
Evan Stade, chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add Malay to the "Languages and Input" configuration screen. BUG=crosbug.com/p/8288 TEST=manual and ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138189

Patch Set 1 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-21 10:10:21 UTC) #1
Nikita (slow)
lgtm
8 years, 7 months ago (2012-05-21 10:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10408040/3001
8 years, 7 months ago (2012-05-21 14:39:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 10408040-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-21 14:39:57 UTC) #4
jungshik at Google
csliv or estade, can you approve (OWNER)? Thanks On 2012/05/21 14:39:57, I haz the power ...
8 years, 7 months ago (2012-05-21 17:37:02 UTC) #5
zel
lgtm
8 years, 7 months ago (2012-05-21 18:48:50 UTC) #6
csilv
webui LGTM
8 years, 7 months ago (2012-05-21 18:51:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10408040/3001
8 years, 7 months ago (2012-05-21 21:23:29 UTC) #8
commit-bot: I haz the power
Try job failure for 10408040-3001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 22:44:31 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-21 23:19:30 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698