Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8017)

Unified Diff: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc

Issue 10408040: Add Malay to the "Languages and Input" configuration screen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc
diff --git a/chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc b/chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc
index a095d63cffa9657bb3c8540fb4be9985c6748c06..7477af22da52183acb669622025d121da9dec8ef 100644
--- a/chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc
+++ b/chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc
@@ -122,7 +122,7 @@ TEST_F(LanguageOptionsHandlerTest, GetLanguageList) {
scoped_ptr<ListValue> list(
chromeos::options2::CrosLanguageOptionsHandler::GetLanguageList(
descriptors));
- ASSERT_EQ(8U, list->GetSize());
+ ASSERT_EQ(9U, list->GetSize());
DictionaryValue* entry = NULL;
std::string language_code;
@@ -197,6 +197,15 @@ TEST_F(LanguageOptionsHandlerTest, GetLanguageList) {
ASSERT_TRUE(entry->GetString("code", &language_code));
ASSERT_TRUE(entry->GetString("displayName", &display_name));
ASSERT_TRUE(entry->GetString("nativeDisplayName", &native_display_name));
+ EXPECT_EQ("ms", language_code);
+ EXPECT_EQ("Malay", display_name);
+ EXPECT_EQ("Bahasa Melayu", native_display_name);
+
+ // This comes from kExtraLanguages.
+ ASSERT_TRUE(list->GetDictionary(8, &entry));
+ ASSERT_TRUE(entry->GetString("code", &language_code));
+ ASSERT_TRUE(entry->GetString("displayName", &display_name));
+ ASSERT_TRUE(entry->GetString("nativeDisplayName", &native_display_name));
EXPECT_EQ("es-419", language_code);
EXPECT_EQ("Spanish (Latin America)", display_name);
EXPECT_EQ("espa\u00F1ol (Latinoam\u00E9rica)", native_display_name);
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698