Issue 10408015: Revert 137733 - Use a temp data dir for IDB tests so persistence can be verified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10408015: Revert 137733 - Use a temp data dir for IDB tests so persistence can be verified. (Closed)

Created:
8 years, 7 months ago by jsbell

Modified:
8 years, 7 months ago

Reviewers:
jsbell

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 137733 - Use a temp data dir for IDB tests so persistence can be verified. WebCore::IDBFactory always generates specifies an empty string (indicating in-memory storage), and relies on intermediate methods before WebCore::IDBFactoryBackendImpl is reached to rewrite with a non-empty string to use on-disk storage. This patch inserts a test-specific implementation of WebIDBFactory into the middle of the call path to specify a data dir if one was not specified, mirroring what is done in multiprocess Chromium during IPC. Prep work for http://webkit.org/b/83074 Review URL: https://chromiumcodereview.appspot.com/10382180 TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137776

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -50 lines)			Patch
	M	webkit/support/test_webkit_platform_support.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	webkit/support/test_webkit_platform_support.cc	View		2 chunks	+1 line, -49 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages