Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 10382180: Use a temp data dir for IDB tests so persistence can be verified. (Closed)

Created:
8 years, 7 months ago by jsbell
Modified:
8 years, 6 months ago
Reviewers:
tony
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, dgrogan, alecflett
Visibility:
Public.

Description

Use a temp data dir for IDB tests so persistence can be verified. WebCore::IDBFactory always generates specifies an empty string (indicating in-memory storage), and relies on intermediate methods before WebCore::IDBFactoryBackendImpl is reached to rewrite with a non-empty string to use on-disk storage. This patch inserts a test-specific implementation of WebIDBFactory into the middle of the call path to specify a data dir if one was not specified, mirroring what is done in multiprocess Chromium during IPC. Prep work for http://webkit.org/b/83074 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140892

Patch Set 1 #

Patch Set 2 : Don't require a new WebKit API #

Patch Set 3 : Only override if empty #

Patch Set 4 : Move to IDBFactory-specific temp dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M webkit/support/test_webkit_platform_support.cc View 1 2 3 1 chunk +50 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
jsbell
In multi-process Chromium, the full call path is: user script calls indexedDB.open(...) WebCore::IDBFactory::open - calls ...
8 years, 7 months ago (2012-05-16 00:25:19 UTC) #1
jsbell
... and FWIW, the motivating factor for this is crbug.com/76641 via http://webkit.org/83074 - once you ...
8 years, 7 months ago (2012-05-16 00:40:48 UTC) #2
jsbell
tony@ - could you take a look?
8 years, 7 months ago (2012-05-17 18:27:02 UTC) #3
tony
LGTM
8 years, 7 months ago (2012-05-17 18:34:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10382180/4001
8 years, 7 months ago (2012-05-17 19:15:17 UTC) #5
commit-bot: I haz the power
Change committed as 137733
8 years, 7 months ago (2012-05-17 20:56:21 UTC) #6
jsbell
Whoops, causing WebKit layout tests to fail on Windows: storage/indexeddb/pending-version-change-on-exit.html storage/indexeddb/index-basics-workers.html storage/indexeddb/objectstore-basics-workers.html storage/indexeddb/transaction-abort-workers.html Weird that ...
8 years, 7 months ago (2012-05-17 23:59:20 UTC) #7
jsbell
I can repro the failures locally on Windows. pending-version-change-on-exit.html fails (timeout) consistently. I believe it's ...
8 years, 6 months ago (2012-06-04 23:04:41 UTC) #8
jsbell
Debug spew from running the other tests in a batch: [10444:5796:1386275584:ERROR:test_webkit_platform_support.cc(375)] Temp dir: C:\Users\jsbell\AppData\Local\Temp\scoped_dir10444_18969 ERROR: ...
8 years, 6 months ago (2012-06-04 23:06:21 UTC) #9
jsbell
I believe the failures were due to workers holding on to leveldb locks longer than ...
8 years, 6 months ago (2012-06-06 21:24:49 UTC) #10
tony
Seems OK. LGTM
8 years, 6 months ago (2012-06-06 22:02:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10382180/17001
8 years, 6 months ago (2012-06-06 22:32:58 UTC) #12
commit-bot: I haz the power
8 years, 6 months ago (2012-06-07 00:05:31 UTC) #13
Change committed as 140892

Powered by Google App Engine
This is Rietveld 408576698