Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 10408009: ui: Change ListModel to operate in size_t instead of int. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ui: Change ListModel to operate in size_t instead of int. R=xiyuan@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137862

Patch Set 1 : #

Patch Set 2 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -49 lines) Patch
M chrome/browser/ui/views/ash/app_list/app_list_model_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/app_list/app_list_model_builder_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_model.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/app_list/app_list_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/app_list_model_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/app_list/app_list_model_view.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ui/base/models/list_model.h View 3 chunks +14 lines, -14 lines 0 comments Download
M ui/base/models/list_model_observer.h View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/base/models/list_model_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 7 months ago (2012-05-17 16:10:39 UTC) #1
xiyuan
8 years, 7 months ago (2012-05-17 16:17:33 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698