Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc

Issue 10408009: ui: Change ListModel to operate in size_t instead of int. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unittest Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc
diff --git a/chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc b/chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc
index adc8d603547d70e227a32f7f5d57387711909634..ce6c67f4409221f7a4cb68bb6ff51b0592c315cb 100644
--- a/chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc
+++ b/chrome/browser/ui/views/ash/app_list/app_list_model_builder.cc
@@ -151,7 +151,7 @@ void AppListModelBuilder::InsertItemByTitle(app_list::AppListItemModel* item) {
l10n_util::StringComparator<string16> c(collator.get());
ModelItemSortData data(item);
- for (int i = special_items_count_; i < model_->item_count(); ++i) {
+ for (size_t i = special_items_count_; i < model_->item_count(); ++i) {
ModelItemSortData current(model_->GetItemAt(i));
if (!c(current.key, data.key)) {
model_->AddItemAt(i, item);
@@ -204,7 +204,7 @@ void AppListModelBuilder::CreateSpecialItems() {
int AppListModelBuilder::FindApp(const std::string& app_id) {
DCHECK(model_);
- for (int i = special_items_count_; i < model_->item_count(); ++i) {
+ for (size_t i = special_items_count_; i < model_->item_count(); ++i) {
ChromeAppListItem* item =
static_cast<ChromeAppListItem*>(model_->GetItemAt(i));
if (item->type() != ChromeAppListItem::TYPE_APP)

Powered by Google App Engine
This is Rietveld 408576698