Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10408003: Plumb extra_data() to VideoDecodeAccelerator (Closed)

Created:
8 years, 7 months ago by sail
Modified:
8 years, 5 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org, viettrungluu
Visibility:
Public.

Description

Plumb extra_data() to VideoDecodeAccelerator We need the SPS and PPS header data to initialize the Mac H.264 hardware video decoder. This CL plubms that data from clients to media::VideoDecodeAccelerator implementations. BUG=127414 TEST=

Patch Set 1 #

Patch Set 2 : rev interface versino #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -83 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/media/mac_video_decode_accelerator.h View 1 chunk +3 lines, -7 lines 0 comments Download
M content/common/gpu/media/mac_video_decode_accelerator.mm View 1 chunk +11 lines, -11 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/pepper_platform_video_decoder_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_decoder_factories.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_decoder_factories.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +4 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +7 lines, -1 line 0 comments Download
M media/video/video_decode_accelerator.h View 1 chunk +8 lines, -2 lines 0 comments Download
M ppapi/api/dev/ppb_video_decoder_dev.idl View 1 2 chunks +11 lines, -2 lines 0 comments Download
M ppapi/c/dev/ppb_video_decoder_dev.h View 1 5 chunks +15 lines, -6 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ppapi/examples/video_decode/video_decode.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.h View 2 chunks +6 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +4 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_video_decoder_thunk.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
Hi Ami, let me know if you think this approach is alright. I'll add the ...
8 years, 7 months ago (2012-05-16 22:51:01 UTC) #1
sail
Adding wez for changes to ppb_video_decoder_dev.idl
8 years, 7 months ago (2012-05-17 02:02:45 UTC) #2
Ami GONE FROM CHROMIUM
Can you use http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/h264_parser.h?view=markupto avoid the need for this CL entirely? (this is a more ...
8 years, 7 months ago (2012-05-17 18:26:33 UTC) #3
Ami GONE FROM CHROMIUM
8 years, 5 months ago (2012-07-05 23:24:07 UTC) #4 
I think this issue can be closed in favor of (the already-landed)
https://chromiumcodereview.appspot.com/10411085

Powered by Google App Engine
This is Rietveld 408576698