Issue 10407025: browser: Add include rules to prevent people including from chrome/browser/ui/views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10407025: browser: Add include rules to prevent people including from chrome/browser/ui/views. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

browser: Add include rules to prevent people including from chrome/browser/ui/views. Whitelist some includes for now until they are fixed. BUG=125846 TEST= run ./tools/checkdeps/checkdeps.py, it should succeed. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137704

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	chrome/browser/DEPS	View		1 chunk	+37 lines, -0 lines	1 comment	Download
	A	chrome/browser/ui/views/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/10407025/diff/1/chrome/browser/DEPS File chrome/browser/DEPS (right): http://codereview.chromium.org/10407025/diff/1/chrome/browser/DEPS#newcode9 chrome/browser/DEPS:9: "+chrome/views", ouch, what is this?! :)

8 years, 7 months ago (2012-05-17 18:17:11 UTC) #1

Ben Goodger (Google)

On 2012/05/17 18:17:11, tfarina wrote: > http://codereview.chromium.org/10407025/diff/1/chrome/browser/DEPS > File chrome/browser/DEPS (right): > > http://codereview.chromium.org/10407025/diff/1/chrome/browser/DEPS#newcode9 > ...

8 years, 7 months ago (2012-05-17 18:19:10 UTC) #2

lgtm

Expand Messages | Collapse Messages