Chromium Code Reviews Chromium Code Reviews
Issue 10407025:
browser: Add include rules to prevent people including from chrome/browser/ui/views. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 "+breakpad", | 2 "+breakpad", |
| 3 "+chrome/app", | 3 "+chrome/app", |
| 4 "+chrome/app/locales", | 4 "+chrome/app/locales", |
| 5 "+chrome/installer", | 5 "+chrome/installer", |
| 6 "+chrome/personalization", | 6 "+chrome/personalization", |
| 7 "+chrome/profile_import", | 7 "+chrome/profile_import", |
| 8 "+chrome/tools/profiles", # For history unit tests. | 8 "+chrome/tools/profiles", # For history unit tests. |
| 9 "+chrome/views", | 9 "+chrome/views", |
|
tfarina
2012/05/17 18:17:12
ouch, what is this?! :)
| |
| 10 "+chromeos", | 10 "+chromeos", |
| 11 "+content/plugin/plugin_interpose_util_mac.h", | 11 "+content/plugin/plugin_interpose_util_mac.h", |
| 12 "+content/public/browser", | 12 "+content/public/browser", |
| 13 "+google_update", | 13 "+google_update", |
| 14 "+grit", # For generated headers | 14 "+grit", # For generated headers |
| 15 "+policy", # For generated headers and source | 15 "+policy", # For generated headers and source |
| 16 "+ppapi/c", # For various types. | 16 "+ppapi/c", # For various types. |
| 17 "+ppapi/proxy", | 17 "+ppapi/proxy", |
| 18 "+ppapi/shared_impl/api_id.h", | 18 "+ppapi/shared_impl/api_id.h", |
| 19 "+rlz", | 19 "+rlz", |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 34 "+xib_localizers", # For generated mac localization helpers | 34 "+xib_localizers", # For generated mac localization helpers |
| 35 | 35 |
| 36 "-content/browser", | 36 "-content/browser", |
| 37 # TODO(jam): Need to remove all these and use only content/public. BUG=98716 | 37 # TODO(jam): Need to remove all these and use only content/public. BUG=98716 |
| 38 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW! | 38 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW! |
| 39 "+content/browser/geolocation/wifi_data_provider_common.h", | 39 "+content/browser/geolocation/wifi_data_provider_common.h", |
| 40 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST! | 40 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST! |
| 41 | 41 |
| 42 "-content/common", | 42 "-content/common", |
| 43 | 43 |
| 44 "-chrome/browser/ui/views", | |
| 45 # TODO(tfarina): Remove all these. crbug.com/125846. | |
| 46 # DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW! | |
| 47 "+chrome/browser/ui/views/ash/brightness_controller_chromeos.h", | |
| 48 "+chrome/browser/ui/views/ash/caps_lock_handler.h", | |
| 49 "+chrome/browser/ui/views/ash/chrome_shell_delegate.h", | |
| 50 "+chrome/browser/ui/views/ash/ime_controller_chromeos.h", | |
| 51 "+chrome/browser/ui/views/ash/key_rewriter.h", | |
| 52 "+chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.h", | |
| 53 "+chrome/browser/ui/views/ash/panel_view_aura.h", | |
| 54 "+chrome/browser/ui/views/ash/screenshot_taker.h", | |
| 55 "+chrome/browser/ui/views/ash/user_gesture_handler.h", | |
| 56 "+chrome/browser/ui/views/ash/volume_controller_chromeos.h", | |
| 57 "+chrome/browser/ui/views/bookmarks/bookmark_bar_view.h", | |
| 58 "+chrome/browser/ui/views/browser_actions_container.h", | |
| 59 "+chrome/browser/ui/views/chrome_views_delegate.h", | |
| 60 "+chrome/browser/ui/views/constrained_window_views.h", | |
| 61 "+chrome/browser/ui/views/event_utils.h", | |
| 62 "+chrome/browser/ui/views/extensions/extension_dialog.h", | |
| 63 "+chrome/browser/ui/views/extensions/extension_dialog_observer.h", | |
| 64 "+chrome/browser/ui/views/extensions/extension_popup.h", | |
| 65 "+chrome/browser/ui/views/extensions/extension_view.h", | |
| 66 "+chrome/browser/ui/views/frame/browser_view.h", | |
| 67 "+chrome/browser/ui/views/infobars/infobar_container_view.h", | |
| 68 "+chrome/browser/ui/views/location_bar/location_bar_view.h", | |
| 69 "+chrome/browser/ui/views/location_bar/location_icon_view.h", | |
| 70 "+chrome/browser/ui/views/notifications/balloon_view.h", | |
| 71 "+chrome/browser/ui/views/notifications/balloon_view_host.h", | |
| 72 "+chrome/browser/ui/views/page_info_bubble_view.h", | |
| 73 "+chrome/browser/ui/views/reload_button.h", | |
| 74 "+chrome/browser/ui/views/select_file_dialog_extension.h", | |
| 75 "+chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h", | |
| 76 "+chrome/browser/ui/views/toolbar_view.h", | |
| 77 "+chrome/browser/ui/views/unhandled_keyboard_event_handler.h", | |
| 78 "+chrome/browser/ui/views/web_dialog_view.h", | |
| 79 # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST! | |
| 80 | |
| 44 # Other libraries. | 81 # Other libraries. |
| 45 "+chrome/third_party/mozilla_security_manager", | 82 "+chrome/third_party/mozilla_security_manager", |
| 46 "+libxml", # For search engine definition parsing. | 83 "+libxml", # For search engine definition parsing. |
| 47 "+third_party/apple_sample_code", # Apple code ImageAndTextCell. | 84 "+third_party/apple_sample_code", # Apple code ImageAndTextCell. |
| 48 "+third_party/cld", | 85 "+third_party/cld", |
| 49 "+third_party/expat", | 86 "+third_party/expat", |
| 50 "+third_party/iaccessible2", | 87 "+third_party/iaccessible2", |
| 51 "+third_party/icu", | 88 "+third_party/icu", |
| 52 "+third_party/isimpledom", | 89 "+third_party/isimpledom", |
| 53 "+third_party/leveldatabase", | 90 "+third_party/leveldatabase", |
| 54 "+third_party/libevent", # For the remote V8 debugging server | 91 "+third_party/libevent", # For the remote V8 debugging server |
| 55 "+third_party/libjingle", | 92 "+third_party/libjingle", |
| 56 "+third_party/protobuf/src/google/protobuf", | 93 "+third_party/protobuf/src/google/protobuf", |
| 57 "+third_party/sqlite", | 94 "+third_party/sqlite", |
| 58 "+third_party/undoview", | 95 "+third_party/undoview", |
| 59 | 96 |
| 60 # FIXME: these should probably not be here, we need to find a better | 97 # FIXME: these should probably not be here, we need to find a better |
| 61 # structure for these includes. | 98 # structure for these includes. |
| 62 "+chrome/renderer", | 99 "+chrome/renderer", |
| 63 ] | 100 ] |
| OLD | NEW |
