runtime/vm/code_generator_ia32.cc - Issue 10407019: Extend assembler with ability to produce comments for the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 10407019: Extend assembler with ability to produce comments for the generated code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Srdjan comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_ia32.cc

diff --git a/runtime/vm/code_generator_ia32.cc b/runtime/vm/code_generator_ia32.cc

index 252159e67776d9b504e91975a01ae0fd70769167..8757b886b6677ed305ad5e69b103592f04407c05 100644

--- a/runtime/vm/code_generator_ia32.cc

+++ b/runtime/vm/code_generator_ia32.cc

@@ -267,6 +267,11 @@ void CodeGenerator::FinalizeExceptionHandlers(const Code& code) {

}

+void CodeGenerator::FinalizeComments(const Code& code) {

+ code.set_comments(assembler_->GetCodeComments());

void CodeGenerator::GenerateLoadVariable(Register dst,

const LocalVariable& variable) {

if (variable.is_captured()) {

« no previous file with comments | « runtime/vm/code_generator_ia32.h ('k') | runtime/vm/code_generator_x64.h » ('j') | runtime/vm/disassembler_ia32.cc » ('J')