runtime/vm/disassembler_ia32.cc - Issue 10407019: Extend assembler with ability to produce comments for the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 10407019: Extend assembler with ability to produce comments for the generated code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Srdjan comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_ia32.cc

diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc

index 24ca193e55b53a7515c5bfcaa85d32e9e52586ea..1c52d72f7fd129c78cda410e5daba910fb5c0c6d 100644

--- a/runtime/vm/disassembler_ia32.cc

+++ b/runtime/vm/disassembler_ia32.cc

@@ -1577,7 +1577,9 @@ int Disassembler::DecodeInstruction(char* hex_buffer, intptr_t hex_size,

void Disassembler::Disassemble(uword start,

uword end,

- DisassemblyFormatter* formatter) {

+ DisassemblyFormatter* formatter,

+ const Code::Comments& comments) {

+ // TODO(vegorov) Decode and display comments.

srdjan 2012/05/17 21:30:37 Typically: "TODO(vegorov):" (add colon).

ASSERT(formatter != NULL);

char hex_buffer[kHexadecimalBufferSize]; // Instruction in hexadecimal form.

char human_buffer[kUserReadableBufferSize]; // Human-readable instruction.

« no previous file with comments | « runtime/vm/disassembler.h ('k') | runtime/vm/disassembler_x64.cc » ('j') | runtime/vm/object.cc » ('J')