Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10399114: I am somewhat reluctantly changing the API so that setProcFD is no longer (Closed)

Created:
8 years, 7 months ago by Markus (顧孟勤)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn
Visibility:
Public.

Description

I am somewhat reluctantly changing the API so that setProcFD is no longer idempotent with regards to global state. But Julien Tinnes convinced me that we should try to hold on to /proc for as short a time as possible. This change potentially makes things a little more difficult for callers, as they can now no longer re-use the file descriptor passed into setProcFd(), so I updated the comments to warn about the changed semantics. BUG=n/a TEST=make test Committed: https://code.google.com/p/seccompsandbox/source/detail?r=186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M sandbox.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M sandbox_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Markus (顧孟勤)
I am not incredibly happy about this change, as it conceivably makes things a little ...
8 years, 7 months ago (2012-05-21 22:54:19 UTC) #1
jln (very slow on Chromium)
8 years, 7 months ago (2012-05-21 23:05:41 UTC) #2
On 2012/05/21 22:54:19, Markus (顧孟勤) wrote:
> I am not incredibly happy about this change, as it conceivably makes things a
> little more difficult for the users of this code. But Julien convinced me that
> we need this.

LGTM

Powered by Google App Engine
This is Rietveld 408576698