sandbox_impl.h - Issue 10399114: I am somewhat reluctantly changing the API so that setProcFD is no longer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox_impl.h

Issue 10399114: I am somewhat reluctantly changing the API so that setProcFD is no longer (Closed) Base URL: http://seccompsandbox.googlecode.com/svn/trunk/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox_impl.h

===================================================================

--- sandbox_impl.h (revision 184)

+++ sandbox_impl.h (working copy)

@@ -79,11 +79,10 @@

// The sandbox needs to be able to access "/proc/self/maps". If this file

// is not accessible when "startSandbox()" gets called, the caller can

- // provide an already opened file descriptor by calling "setProcSelf()".

+ // provide an already opened file descriptor by calling "setProcFd()".

// The sandbox becomes the newer owner of this file descriptor and will

- // eventually close it when "startSandbox()" executes. But if the caller

- // never ends up calling startSandbox(), then the caller must close the

- // file descriptor.

+ // eventually close it. After calling setProcFd(), the caller MUST eventually

+ // call startSandbox(), or resources could be leaked.

static void setProcFd(int proc) asm("SeccompSandboxSetProcFd");

// This is the main public entry point. It finds all system calls that

« no previous file with comments | « sandbox.cc ('k') | no next file » | no next file with comments »