Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 10399063: Revert 137657 - Remove directory_path argument from chromeos::FindEntryCallback (Closed)

Created:
8 years, 7 months ago by satorux1
Modified:
8 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 137657 - Remove directory_path argument from chromeos::FindEntryCallback Nothing is wrong with this patch, but we don't want to submit refactoring patches until M20 issues are fixed. BUG=126672 TEST=unit_tests --gtest_filter="GData*" Review URL: https://chromiumcodereview.appspot.com/10383156 TBR=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M chrome/browser/chromeos/gdata/find_entry_callback.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/find_entry_callback.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 8 chunks +19 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
satorux1
8 years, 7 months ago (2012-05-17 14:57:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698