Issue 10383156: Remove directory_path argument from chromeos::FindEntryCallback

Issue 10383156: Remove directory_path argument from chromeos::FindEntryCallback (Closed)

Created:
8 years, 7 months ago by hashimoto

Modified:
8 years, 6 months ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove directory_path argument from chromeos::FindEntryCallback BUG=126672 TEST=unit_tests --gtest_filter="GData*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137657

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -42 lines)			Patch
M	chrome/browser/chromeos/gdata/find_entry_callback.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/find_entry_callback.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		8 chunks	+8 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download

Total messages: 7 (0 generated)

satorux1

LGTM, but please wait for 3-4 days before submitting this. We are in the process ...

8 years, 7 months ago (2012-05-14 07:05:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10383156/7001

8 years, 7 months ago (2012-05-17 13:22:19 UTC) #3

satorux1

oops. this was a bit too early. i'm going to revert this for now, so ...

8 years, 7 months ago (2012-05-17 14:51:51 UTC) #5

hashimoto

On 2012/05/17 14:51:51, satorux1 wrote: > oops. this was a bit too early. i'm going ...

8 years, 7 months ago (2012-05-17 15:00:39 UTC) #6

satorux1

8 years, 6 months ago (2012-05-29 11:53:32 UTC) #7

Could you revive this patch? Refactoring patches are now welcome!