Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/metrics/metrics_service_browsertest.cc

Issue 10399046: Remove virtual keyboard support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: final rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service_browsertest.cc
diff --git a/chrome/browser/metrics/metrics_service_browsertest.cc b/chrome/browser/metrics/metrics_service_browsertest.cc
index af81a17b83275091af40c09acbdb01140a64786d..cd12e44e44bcbd73605df84599b24c900f15c5de 100644
--- a/chrome/browser/metrics/metrics_service_browsertest.cc
+++ b/chrome/browser/metrics/metrics_service_browsertest.cc
@@ -62,12 +62,7 @@ IN_PROC_BROWSER_TEST_F(MetricsServiceTest, CloseRenderersNormally) {
// Verify that the expected stability metrics were recorded.
const PrefService* prefs = g_browser_process->local_state();
EXPECT_EQ(1, prefs->GetInteger(prefs::kStabilityLaunchCount));
-#if defined(USE_VIRTUAL_KEYBOARD)
- // The keyboard page loads.
- EXPECT_EQ(4, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-#else
EXPECT_EQ(3, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-#endif
EXPECT_EQ(0, prefs->GetInteger(prefs::kStabilityRendererCrashCount));
// TODO(isherman): We should also verify that prefs::kStabilityExitedCleanly
// is set to true, but this preference isn't set until the browser
@@ -97,12 +92,7 @@ IN_PROC_BROWSER_TEST_F(MetricsServiceTest, CrashRenderers) {
// Verify that the expected stability metrics were recorded.
EXPECT_EQ(1, prefs->GetInteger(prefs::kStabilityLaunchCount));
-#if defined(USE_VIRTUAL_KEYBOARD)
- // The keyboard page loads.
- EXPECT_EQ(5, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-#else
EXPECT_EQ(4, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-#endif
EXPECT_EQ(1, prefs->GetInteger(prefs::kStabilityRendererCrashCount));
// TODO(isherman): We should also verify that prefs::kStabilityExitedCleanly
// is set to true, but this preference isn't set until the browser
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698