Issue 10399026: Add a global graph entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10399026: Add a global graph entry. (Closed)

Created:
8 years, 7 months ago by Kevin Millikin (Google)

Modified:
8 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a global graph entry. Ensure all blocks including exception handlers are reachable from the entry. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7681

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -38 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+17 lines, -26 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	3 chunks	+38 lines, -4 lines	1 comment	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+38 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This change was committed TBR as it is blocking another change that has been reviewed. ...

8 years, 7 months ago (2012-05-16 12:36:28 UTC) #3

srdjan

8 years, 7 months ago (2012-05-16 15:20:27 UTC) #4

LGTM

https://chromiumcodereview.appspot.com/10399026/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10399026/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:1285: ZoneGrowableArray<TargetEntryInstr*>
catch_entries_;
GrowableArray, since it is a value object.

Expand Messages | Collapse Messages