Issue 10392108: Only close popup bubble when a tab switch happens.

Issue 10392108: Only close popup bubble when a tab switch happens. (Closed)

Created:
8 years, 7 months ago by Avi (use Gerrit)

Modified:
8 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only close popup bubble when a tab switch happens. BUG=127471 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137433

Patch Set 4 : rebase only #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -36 lines)			Patch
M	chrome/browser/ui/cocoa/base_bubble_controller.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/base_bubble_controller.mm	View	1	5 chunks	+24 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

If you're looking for notification that the tabs switched, that's what to listen for. Otherwise ...

8 years, 7 months ago (2012-05-15 16:42:40 UTC) #1

Robert Sesek

LGTM https://chromiumcodereview.appspot.com/10392108/diff/1/chrome/browser/ui/cocoa/base_bubble_controller.mm File chrome/browser/ui/cocoa/base_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/10392108/diff/1/chrome/browser/ui/cocoa/base_bubble_controller.mm#newcode15 chrome/browser/ui/cocoa/base_bubble_controller.mm:15: #include "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h" #import

8 years, 7 months ago (2012-05-15 20:08:11 UTC) #2

Avi (use Gerrit)

https://chromiumcodereview.appspot.com/10392108/diff/1/chrome/browser/ui/cocoa/base_bubble_controller.mm File chrome/browser/ui/cocoa/base_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/10392108/diff/1/chrome/browser/ui/cocoa/base_bubble_controller.mm#newcode15 chrome/browser/ui/cocoa/base_bubble_controller.mm:15: #include "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h" On 2012/05/15 20:08:11, rsesek wrote: > #import ...

8 years, 7 months ago (2012-05-15 20:20:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10392108/6001

8 years, 7 months ago (2012-05-15 20:21:24 UTC) #4

commit-bot: I haz the power

Try job failure for 10392108-6001 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 7 months ago (2012-05-15 21:24:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10392108/2004

8 years, 7 months ago (2012-05-16 14:45:54 UTC) #6

Change committed as 137433

Expand Messages | Collapse Messages