Only close popup bubble when a tab switch happens.

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/closure_blocks_leopard_compat.h"
 #include "base/mac/mac_util.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/string_util.h"
+#import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_types.h"
+#include "chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h"

[Robert Sesek, 2012/05/15 20:08:11]

#import

[Avi (use Gerrit), 2012/05/15 20:20:02]

Done.

 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 @interface BaseBubbleController (Private)
 - (void)updateOriginFromAnchor;
+- (void)activateTabWithContents:(TabContentsWrapper*)newContents
+               previousContents:(TabContentsWrapper*)oldContents
+                        atIndex:(NSInteger)index
+                    userGesture:(bool)wasUserGesture;
 @end
 
 #if !defined(MAC_OS_X_VERSION_10_6) || \
     MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_6
 typedef unsigned long long NSEventMask;
 
 @interface NSEvent (SnowLeopardDeclarations)
 + (id)addLocalMonitorForEventsMatchingMask:(NSEventMask)mask
                                    handler:(NSEvent* (^)(NSEvent*))block;
 + (void)removeMonitor:(id)eventMonitor;
 @end
 
 @interface NSOperationQueue (SnowLeopardDeclarations)
 + (id)mainQueue;
 @end
 
 @interface NSNotificationCenter (SnowLeopardDeclarations)
 - (id)addObserverForName:(NSString*)name
                   object:(id)obj
                    queue:(NSOperationQueue*)queue
               usingBlock:(void (^)(NSNotification*))block;
 @end
 #endif  // MAC_OS_X_VERSION_10_6
 
-namespace BaseBubbleControllerInternal {
-
-// This bridge listens for notifications so that the bubble closes when a user
-// switches tabs (including by opening a new one).
-class Bridge : public content::NotificationObserver {
- public:
-  explicit Bridge(BaseBubbleController* controller) : controller_(controller) {
-    registrar_.Add(this, content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
-        content::NotificationService::AllSources());
-  }
-
-  // content::NotificationObserver:
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) {
-    [controller_ close];
-  }
-
- private:
-  BaseBubbleController* controller_;  // Weak, owns this.
-  content::NotificationRegistrar registrar_;
-};
-
-}  // namespace BaseBubbleControllerInternal
-
 @implementation BaseBubbleController
 
 @synthesize parentWindow = parentWindow_;
 @synthesize anchorPoint = anchor_;
 @synthesize bubble = bubble_;
 
 - (id)initWithWindowNibPath:(NSString*)nibPath
                parentWindow:(NSWindow*)parentWindow
                  anchoredAt:(NSPoint)anchoredAt {
   nibPath = [base::mac::FrameworkBundle() pathForResource:nibPath
@@ skipping 53 matching lines @@
   }
   return self;
 }
 
 - (void)awakeFromNib {
   // Check all connections have been made in Interface Builder.
   DCHECK([self window]);
   DCHECK(bubble_);
   DCHECK_EQ(self, [[self window] delegate]);
 
-  baseBridge_.reset(new BaseBubbleControllerInternal::Bridge(self));
+  BrowserWindowController* bwc =
+      [BrowserWindowController browserWindowControllerForWindow:parentWindow_];
+  if (bwc) {
+    TabStripController* tabStripController = [bwc tabStripController];
+    TabStripModel* tabStripModel = [tabStripController tabStripModel];
+    tabStripObserverBridge_.reset(new TabStripModelObserverBridge(tabStripModel,
+                                                                  self));
+  }
 
   [bubble_ setArrowLocation:info_bubble::kTopRight];
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super dealloc];
 }
 
 - (void)setAnchorPoint:(NSPoint)anchor {
@@ skipping 42 matching lines @@
     eventTap_ = nil;
   }
   if (resignationObserver_) {
     [[NSNotificationCenter defaultCenter]
         removeObserver:resignationObserver_
                   name:NSWindowDidResignKeyNotification
                 object:nil];
     resignationObserver_ = nil;
   }
 
+  tabStripObserverBridge_.reset();
+
   [[[self window] parentWindow] removeChildWindow:[self window]];
   [super close];
 }
 
 // The controller is the delegate of the window so it receives did resign key
 // notifications. When key is resigned mirror Windows behavior and close the
 // window.
 - (void)windowDidResignKey:(NSNotification*)notification {
   NSWindow* window = [self window];
   DCHECK_EQ([notification object], window);
@@ skipping 80 matching lines @@
       break;
 
     default:
       NOTREACHED();
   }
 
   origin.y -= NSHeight([window frame]);
   [window setFrameOrigin:origin];
 }
 
+- (void)activateTabWithContents:(TabContentsWrapper*)newContents
+               previousContents:(TabContentsWrapper*)oldContents
+                        atIndex:(NSInteger)index
+                    userGesture:(bool)wasUserGesture {
+  // The user switched tabs; close.
+  [self close];
+}
+
 @end  // BaseBubbleController