Issue 10392091: Disabling precompiled headers for official builds with msvs2010

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10392091: Disabling precompiled headers for official builds with msvs2010 (Closed)

Created:
8 years, 7 months ago by bradn

Modified:
7 years, 2 months ago

Reviewers:
kerz_chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disabling precompiled headers for official builds with msvs2010 Selectively disabling precompiled headers for release builds with msvs2010 Precompiled headers seem to interact badly with auto-sharding using the msvs_shard option. BUG=http://code.google.com/p/chromium/issues/detail?id=127875 TEST=builds on trybots. R=kerz@chromium.org

Patch Set 1 #

Patch Set 2 : tpo #

Patch Set 3 : reup #

Patch Set 4 : merge #

Patch Set 5 : fix accidental move #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	build/common.gypi	View	1 2 3 4	5 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Submitting TBR (trybots seem down)

Expand Messages | Collapse Messages