validator_ragel: Use different actions for different types of commands

Use different actions for different types of commands

This reduced compilation time on Windows by another 10%.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2737
TEST=functionality must be left unchanged
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8584

[pasko-google - do not use, 2012-05-12 13:54:31]

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
File src/trusted/validator_ragel/unreviewed/gen-dfa.cc (right):

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1813: fprintf(out_file, "
@operand%zd_%s", operand_index, it->second);
80

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1813: fprintf(out_file, "
@operand%zd_%s", operand_index, it->second);
80

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1815: rm_half_enabled = true;
if (enabled(Actions::kParseOperandPositions) || operand_allows_mem(operand)) {
  fprintf(out_file, " @operand ...

bool has_mem_operand() {
  for (auto operand_it = operands.begin(); operand_it != operands.end();
++operand_it) {
    if (allows_mem(*operand_it)) {
      return TRUE;
    }
  }
  return false;
}

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1849: void
print_instruction_processing() {
print_inst_end_actions

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
File src/trusted/validator_ragel/unreviewed/validator-x86_64.rl (right):

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:118: /* If Sandboxed
Rsi is destroyed then we must note that.  */
s/note/detect/

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:152:
restricted_register = operand_states & 0x0f;
copy the proposed comment above this line too

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:169: /* If Sandboxed
Rsi is destroyed then we must note that.  */
ditto

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:215:
restricted_register = operand_states & 0x0f;
/* Take 2 bits of operand type from "operand_states" as restricted_register,
make sure operand_states denotes a register (4th bit == 0). */

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:217:
(OperandSandboxRestricted << (5 + 8))) {
align with shiftwidth=4

[khim, 2012-05-12 14:32:16]

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
File src/trusted/validator_ragel/unreviewed/gen-dfa.cc (right):

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1815: rm_half_enabled = true;
On 2012/05/12 13:54:31, pasko wrote:
> if (enabled(Actions::kParseOperandPositions) || operand_allows_mem(operand)) {
>   fprintf(out_file, " @operand ...
> 
> bool has_mem_operand() {
>   for (auto operand_it = operands.begin(); operand_it != operands.end();
> ++operand_it) {
>     if (allows_mem(*operand_it)) {
>       return TRUE;
>     }
>   }
>   return false;
> }

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1849: void
print_instruction_processing() {
On 2012/05/12 13:54:31, pasko wrote:
> print_inst_end_actions

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
File src/trusted/validator_ragel/unreviewed/validator-x86_64.rl (right):

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:118: /* If Sandboxed
Rsi is destroyed then we must note that.  */
On 2012/05/12 13:54:31, pasko wrote:
> s/note/detect/

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:152:
restricted_register = operand_states & 0x0f;
On 2012/05/12 13:54:31, pasko wrote:
> copy the proposed comment above this line too

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:169: /* If Sandboxed
Rsi is destroyed then we must note that.  */
On 2012/05/12 13:54:31, pasko wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:215:
restricted_register = operand_states & 0x0f;
On 2012/05/12 13:54:31, pasko wrote:
> /* Take 2 bits of operand type from "operand_states" as restricted_register,
> make sure operand_states denotes a register (4th bit == 0). */

Done.

https://chromiumcodereview.appspot.com/10392066/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator-x86_64.rl:217:
(OperandSandboxRestricted << (5 + 8))) {
On 2012/05/12 13:54:31, pasko wrote:
> align with shiftwidth=4

Done.

[pasko-google - do not use, 2012-05-12 15:16:06]

https://chromiumcodereview.appspot.com/10392066/diff/4005/src/trusted/validat...
File src/trusted/validator_ragel/unreviewed/gen-dfa.cc (right):

https://chromiumcodereview.appspot.com/10392066/diff/4005/src/trusted/validat...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1858: --operands_count;
/* Memory operand is processed with action @check_access. */

[khim, 2012-05-12 15:19:52]

https://chromiumcodereview.appspot.com/10392066/diff/4005/src/trusted/validat...
File src/trusted/validator_ragel/unreviewed/gen-dfa.cc (right):

https://chromiumcodereview.appspot.com/10392066/diff/4005/src/trusted/validat...
src/trusted/validator_ragel/unreviewed/gen-dfa.cc:1858: --operands_count;
On 2012/05/12 15:16:06, pasko wrote:
> /* Memory operand is processed with action @check_access. */

Done.

[pasko-google - do not use, 2012-05-12 15:27:22]

lgtm