Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: lib/compiler/implementation/typechecker.dart

Issue 10392024: Add a "Label" Node around an Identifier that is being used as a label. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Only use Label nodes for label introductions. Include the colon. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/typechecker.dart
diff --git a/lib/compiler/implementation/typechecker.dart b/lib/compiler/implementation/typechecker.dart
index 8c69f55ddf23a1076295f490ad9c5933d78a8b98..11c88501b6701f0b2356c706d153f3f74da3c748 100644
--- a/lib/compiler/implementation/typechecker.dart
+++ b/lib/compiler/implementation/typechecker.dart
@@ -703,6 +703,10 @@ class TypeCheckerVisitor implements Visitor<Type> {
return bodyType.join(StatementType.NOT_RETURNING);
}
+ visitLabel(Label node) {
+ fail(node);
ahe 2012/05/10 11:52:30 No need to fail here. Just do nothing.
Lasse Reichstein Nielsen 2012/05/10 12:14:20 Done. Why do we need to fail in the cases below?
ahe 2012/05/10 12:40:25 Ask Karl. The cases below are not implemented so t
+ }
+
visitLabeledStatement(LabeledStatement node) {
return node.statement.accept(this);
}
« lib/compiler/implementation/tree/nodes.dart ('K') | « lib/compiler/implementation/tree/visitors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698