Add a "Label" Node around an Identifier that is being used as a label.

lib/compiler/implementation/typechecker.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class TypeCheckerTask extends CompilerTask {
   TypeCheckerTask(Compiler compiler) : super(compiler);
   String get name() => "Type checker";
 
   static final bool LOG_FAILURES = false;
 
@@ skipping 685 matching lines @@
   visitContinueStatement(ContinueStatement node) {
     return StatementType.NOT_RETURNING;
   }
 
   visitForIn(ForIn node) {
     analyze(node.expression);
     StatementType bodyType = analyze(node.body);
     return bodyType.join(StatementType.NOT_RETURNING);
   }
 
+  visitLabel(Label node) {
+    fail(node);

[ahe, 2012/05/10 11:52:30]

No need to fail here. Just do nothing.

[Lasse Reichstein Nielsen, 2012/05/10 12:14:20]

Done.
Why do we need to fail in the cases below?

[ahe, 2012/05/10 12:40:25]

Ask Karl. The cases below are not implemented so the type checker gives up (that
is what "fail" means in this context).

+  }
+  
   visitLabeledStatement(LabeledStatement node) {
     return node.statement.accept(this);
   }
 
   visitLiteralMap(LiteralMap node) {
     fail(node);
   }
 
   visitLiteralMapEntry(LiteralMapEntry node) {
     fail(node);
@@ skipping 20 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     fail(node);
   }
 
   visitTypedef(Typedef node) {
     fail(node);
   }
 }