Making sure that base::GetModuleFromAddress() does not increment the module reference counter sinse…

Fix base::GetModuleFromAddress() not to increment the module's reference count,
to match the behaviour expected by calling code.

The original change was reverted by https://chromiumcodereview.appspot.com/10384209.

BUG=124091, 127933
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137547

[alexeypa (please no reviews), 2012-05-16 20:22:55]

Please take a look.

[Wez, 2012-05-16 20:27:50]

LGTM w/ one nit, and in the description:

typo: sinse -> sinse

Suggested description:
"Fix base::GetModuleFromAddress() not to increment the module's reference count,
to match the behaviour expected by calling code."

https://chromiumcodereview.appspot.com/10391169/diff/1/base/process_util.h
File base/process_util.h (right):

https://chromiumcodereview.appspot.com/10391169/diff/1/base/process_util.h#ne...
base/process_util.h:149: // Returns the module handle to which an address
belongs. The reference counter
nit: counter -> count

[alexeypa (please no reviews), 2012-05-16 20:32:13]

FYI

https://chromiumcodereview.appspot.com/10391169/diff/1/base/process_util.h
File base/process_util.h (right):

https://chromiumcodereview.appspot.com/10391169/diff/1/base/process_util.h#ne...
base/process_util.h:149: // Returns the module handle to which an address
belongs. The reference counter
On 2012/05/16 20:27:50, Wez wrote:
> nit: counter -> count

Done.

[jar (doing other things), 2012-05-16 22:16:00]

I'd like Ricardo to have a look at this, as he's much much more familiar with
the Window-isms.

[rvargas (doing something else), 2012-05-16 22:21:49]

lgtm

[jar (doing other things), 2012-05-16 22:41:05]

lgtm