Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 10384209: Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from … (Closed)

Created:
8 years, 7 months ago by alexeypa (please no reviews)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), sadrul, brettw-cc_chromium.org
Visibility:
Public.

Description

Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from each other and add protection from shatter attacks by placing |this| pointer to the used data associated with the message-only window (instead of blindly trusting the value of WPARAM). We suspect that r133134 might be causing issues like 124091, so it needs to be reworked. BUG=124091, 127933 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -73 lines) Patch
M base/message_pump_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/message_pump_win.cc View 8 chunks +25 lines, -60 lines 0 comments Download
M base/process_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/process_util_win.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
Please take a look.
8 years, 7 months ago (2012-05-16 20:22:36 UTC) #1
Wez
On 2012/05/16 20:22:36, alexeypa wrote: > Please take a look. Is this a straight revert ...
8 years, 7 months ago (2012-05-16 21:01:34 UTC) #2
alexeypa (please no reviews)
On 2012/05/16 21:01:34, Wez wrote: > On 2012/05/16 20:22:36, alexeypa wrote: > > Please take ...
8 years, 7 months ago (2012-05-16 21:07:12 UTC) #3
Wez
LGTM, FWIW
8 years, 7 months ago (2012-05-16 21:13:55 UTC) #4
jar (doing other things)
8 years, 7 months ago (2012-05-16 22:13:29 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698