Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10391159: Merge 116556 - [chromium] Check whether an active document loader exists before accessing it (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 116556 - [chromium] Check whether an active document loader exists before accessing it https://bugs.webkit.org/show_bug.cgi?id=85892 Reviewed by Eric Seidel. Although FrameLoader::loadInSameDocument which invokes this method does not have a provisional document loader, we're seeing crashes where the FrameLoader is in provisional state, and thus activeDocumentLoader returns 0. Lacking any understanding of how this can happen, we do this check here to avoid crashing. * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage): TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years, 7 months ago (2012-05-16 07:59:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698