Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Issue 10391152: Merge 136205 - Support scheme-setting for GoogleURLTracker. (Closed)

Created:
8 years, 7 months ago by Peter Kasting
Modified:
8 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 136205 - Support scheme-setting for GoogleURLTracker. This switches the searchdomaincheck request from format=domain (".google.com") to format=url ("http://www.google.com/"). This in turn allows the server to direct us to use HTTPS searches by default, which should save a redirect on each search over the current situation when it's applicable. We hide this detail from the user; we continue to prompt about TLD changes, but we don't prompt about scheme changes. BUG=96636 TEST=Make sure the cookie store has cookies such that you get HTTPS search by default on Google. After this patch, doing a search should not involve a redirect through HTTP. Review URL: https://chromiumcodereview.appspot.com/10382091 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -63 lines) Patch
M chrome/browser/google/google_url_tracker.h View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 8 chunks +68 lines, -31 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 23 chunks +220 lines, -27 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
8 years, 7 months ago (2012-05-15 23:01:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698