Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10391151: Add tool for bots to download a web directory. (Closed)

Created:
8 years, 7 months ago by chrisphan
Modified:
8 years, 7 months ago
Reviewers:
cmp, chrisphan1, Nirnimesh
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Add tool for bots to download a web directory. This script allow buildbot slaves to download dependency files before it run tests. For example 30+ chromebots will retrieve the list of urls and binaries that are not to be checked in the repository. TEST=None BUG=None

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A scripts/slave/download_from_url.py View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
chrisphan
I use to do this using rsync before moving to buildbot. I'm not sure if ...
8 years, 7 months ago (2012-05-16 00:06:13 UTC) #1
cmp
https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py File scripts/slave/download_from_url.py (right): https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py#newcode1 scripts/slave/download_from_url.py:1: #!/usr/bin/python there's a general problem with this approach that ...
8 years, 7 months ago (2012-05-16 17:53:19 UTC) #2
chrisphan1
https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py File scripts/slave/download_from_url.py (right): https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py#newcode1 scripts/slave/download_from_url.py:1: #!/usr/bin/python On 2012/05/16 17:53:19, cmp wrote: > there's a ...
8 years, 7 months ago (2012-05-16 19:22:51 UTC) #3
cmp
https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py File scripts/slave/download_from_url.py (right): https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py#newcode1 scripts/slave/download_from_url.py:1: #!/usr/bin/python Okay, as for the size of the files, ...
8 years, 7 months ago (2012-05-16 20:23:19 UTC) #4
chrisphan1
https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py File scripts/slave/download_from_url.py (right): https://chromiumcodereview.appspot.com/10391151/diff/1/scripts/slave/download_from_url.py#newcode1 scripts/slave/download_from_url.py:1: #!/usr/bin/python On 2012/05/16 20:23:19, cmp wrote: > Okay, as ...
8 years, 7 months ago (2012-05-16 20:45:38 UTC) #5
cmp
In that case this could go into chrome/trunk/tools/chromebot. WDYT?
8 years, 7 months ago (2012-05-16 20:48:42 UTC) #6
chrisphan1
On 2012/05/16 20:48:42, cmp wrote: > In that case this could go into chrome/trunk/tools/chromebot. WDYT? ...
8 years, 7 months ago (2012-05-16 20:53:10 UTC) #7
cmp
+nirnimesh, was there a specific reason not to check them in besides the binary size?
8 years, 7 months ago (2012-05-16 20:55:30 UTC) #8
chrisphan1
This is for the files: top_million_urls minidump_stackwalk (process linux crash dumps) crash_report (process mac crash ...
8 years, 7 months ago (2012-05-16 21:01:26 UTC) #9
Nirnimesh
8 years, 7 months ago (2012-05-16 21:16:25 UTC) #10
Chris, all these 3 files (top_million, minidump_stackwalk, crash_report) should
be checked in.

Powered by Google App Engine
This is Rietveld 408576698