Issue 10391051: Fix flake in chrome_frame_net_tests due to improper use of IE configurator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391051: Fix flake in chrome_frame_net_tests due to improper use of IE configurator. (Closed)

Created:
8 years, 7 months ago by grt (UTC plus 2)

Modified:
8 years, 7 months ago

Reviewers:
erikwright (departed)

CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix flake in chrome_frame_net_tests due to improper use of IE configurator. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136327

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome_frame/test/ie_configurator.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome_frame/test/net/fake_external_tab.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

grt (UTC plus 2)

Two-phase initialization works best when the first phase is followed by the second phase (facepalm).

8 years, 7 months ago (2012-05-10 14:56:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10391051/1

8 years, 7 months ago (2012-05-10 15:07:38 UTC) #3

Change committed as 136327