Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4508)

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 10391051: Fix flake in chrome_frame_net_tests due to improper use of IE configurator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/ie_configurator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/net/fake_external_tab.cc
diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc
index 18914fd18a975873ecf0ab122a8e4af87d17192d..6a6a88481e0ed5a3536c9f5240fd0c8f169e1e14 100644
--- a/chrome_frame/test/net/fake_external_tab.cc
+++ b/chrome_frame/test/net/fake_external_tab.cc
@@ -518,8 +518,10 @@ void CFUrlRequestUnittestRunner::StartChromeFrameInHostBrowser() {
// Tweak IE settings to make it amenable to testing before launching it.
ie_configurator_.reset(chrome_frame_test::CreateConfigurator());
- if (ie_configurator_.get() != NULL)
+ if (ie_configurator_.get() != NULL) {
+ ie_configurator_->Initialize();
ie_configurator_->ApplySettings();
+ }
test_http_server_.reset(new test_server::SimpleWebServer(kTestServerPort));
test_http_server_->AddResponse(&chrome_frame_html_);
« no previous file with comments | « chrome_frame/test/ie_configurator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698