Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 10391041: remove WEBKIT_USING_SKIA (Closed)

Created:
8 years, 7 months ago by jamesr
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

remove WEBKIT_USING_SKIA WEBKIT_USING_SKIA is always set, so having the #ifdef isn't helpful. This just removes the guards. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136632

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -90 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/glue/webcursor_mac.mm View 6 chunks +1 line, -66 lines 0 comments Download
M webkit/glue/webthemeengine_impl_mac.cc View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
This patch is on top of https://chromiumcodereview.appspot.com/10392018/
8 years, 7 months ago (2012-05-09 22:28:59 UTC) #1
darin (slow to review)
LGTM
8 years, 7 months ago (2012-05-10 08:28:30 UTC) #2
jamesr
rebased
8 years, 7 months ago (2012-05-10 21:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10391041/3001
8 years, 7 months ago (2012-05-10 22:58:54 UTC) #4
commit-bot: I haz the power
Try job failure for 10391041-3001 (retry) on android for steps "Compile, build". It's a second ...
8 years, 7 months ago (2012-05-10 23:07:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10391041/3001
8 years, 7 months ago (2012-05-11 17:47:15 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 19:32:11 UTC) #7
Change committed as 136632

Powered by Google App Engine
This is Rietveld 408576698