Make sure only the main browser process and service processes are allowed to create the profile dir…

Make sure only the main browser process and service processes are allowed to create the profile directory.

This patch lets Chrome start with profile located on a network share on
Windows Vista and newer.

BUG=120388
TEST=Start Chrome with --user-data-dir pointing to a network share location and try to navigate to a web page. This should not lead to a hang of the renderer. NaCl and NPAPI plugins should run fine too.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136020

[pastarmovj, 2012-05-08 14:59:44]

Hi Carlos,
Do you mind rubberstamping this CL. It is basically the same code as the CL you
already reviewed here: https://chromiumcodereview.appspot.com/10306009/. I had
to fix the whitelist of processes which is allowed to access the profile with
the NaCl and NPAPI brokers and the gpu process. And I split the CL in three
smaller ones to simplify applying for merge approval for 20.

[cpu_(ooo_6.6-7.5), 2012-05-09 02:00:19]

lgtm

https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/chrome.gyp#newc...
chrome/chrome.gyp:1061: ],
I don't understand this new dependency, looks ok but double check you want it.

https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/common_constant...
File chrome/common_constants.gypi (right):

https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/common_constant...
chrome/common_constants.gypi:89: 'COMPILE_CONTENT_STATICALLY',
no idea what this does. Trust you know.

[pastarmovj, 2012-05-09 12:24:30]

Thanks for the fast review! 

For both of your questions the answer is that there are some projects which use
the chrome_common project and because i now made it require the content_switches
which for chrome is fine but for external projects is an unmet dependency I had
asked around and was adviced to only include the file that is needed without
adding more inter-project dependencies. Also the define
COMPILE_CONTENT_STATICALLY makes sure that the string constants in
content_switches are not dll-[im-ex]ported but linked statically.

The whole discussion about that can be seen here:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...


On 2012/05/09 02:00:19, cpu wrote:
> lgtm
> 
> https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/chrome.gyp
> File chrome/chrome.gyp (right):
> 
>
https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/chrome.gyp#newc...
> chrome/chrome.gyp:1061: ],
> I don't understand this new dependency, looks ok but double check you want it.
> 
>
https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/common_constant...
> File chrome/common_constants.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/10390003/diff/1/chrome/common_constant...
> chrome/common_constants.gypi:89: 'COMPILE_CONTENT_STATICALLY',
> no idea what this does. Trust you know.