Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: chrome/common/chrome_paths_win.cc

Issue 10390003: Make sure only the main browser process and service processes are allowed to create the profile dir… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_paths_win.cc
diff --git a/chrome/common/chrome_paths_win.cc b/chrome/common/chrome_paths_win.cc
index 5eefb78f6250e1b29d4870b750c48ab13ff31218..6f5f9fde6c9ebd97a47bf81db3784049bdcc03e5 100644
--- a/chrome/common/chrome_paths_win.cc
+++ b/chrome/common/chrome_paths_win.cc
@@ -16,6 +16,7 @@
#include "base/win/scoped_co_mem.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/installer/util/browser_distribution.h"
+#include "content/public/common/content_switches.h"
namespace chrome {
@@ -97,4 +98,19 @@ bool GetUserDesktop(FilePath* result) {
return true;
}
+bool ProcessNeedsProfileDir(const std::string& process_type) {
+ // On windows we don't want subprocesses other than the browser process and
+ // service processes to be able to use the profile directory because if it
+ // lies on a network share the sandbox will prevent us from accessing it.
+ // TODO(pastarmovj): For now gpu and plugin broker processes are whitelisted
+ // too because they do use the profile dir in some way but this must be
+ // investigated and fixed if possible.
+ return process_type.empty() ||
+ process_type == switches::kServiceProcess ||
+ process_type == switches::kGpuProcess ||
+ process_type == switches::kNaClBrokerProcess ||
+ process_type == switches::kNaClLoaderProcess ||
+ process_type == switches::kPpapiBrokerProcess;
+}
+
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698