Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8663)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 10389168: Revert 137388 - Move declarative API into events API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/utils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/schema_generated_bindings.js (revision 137393)
+++ chrome/renderer/resources/extensions/schema_generated_bindings.js (working copy)
@@ -5,15 +5,11 @@
// This script contains privileged chrome extension related javascript APIs.
// It is loaded by pages whose URL has the chrome-extension protocol.
- // TODO(battre): cleanup the usage of packages everywhere, as described here
- // http://codereview.chromium.org/10392008/diff/38/chrome/renderer/resources/extensions/schema_generated_bindings.js
-
require('json_schema');
require('event_bindings');
var GetExtensionAPIDefinition =
requireNative('apiDefinitions').GetExtensionAPIDefinition;
var sendRequest = require('sendRequest').sendRequest;
- var utils = require('utils');
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
@@ -26,6 +22,13 @@
var internalAPIs = {};
chromeHidden.internalAPIs = internalAPIs;
+ function forEach(dict, f) {
+ for (key in dict) {
+ if (dict.hasOwnProperty(key))
+ f(key, dict[key]);
+ }
+ }
+
// Validate arguments.
var schemaValidator = new chromeHidden.JSONSchemaValidator();
chromeHidden.validate = function(args, parameterSchemas) {
@@ -507,7 +510,7 @@
if (!properties)
return;
- utils.forEach(properties, function(propertyName, propertyDef) {
+ forEach(properties, function(propertyName, propertyDef) {
if (propertyName in m)
return; // TODO(kalman): be strict like functions/events somehow.
if (!isSchemaNodeSupported(propertyDef, platform, manifestVersion))
« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/utils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698