Move dart:dom to dart:dom_deprecated

Move dart:dom to dart:dom_deprecated

Brian: Can you please look at the editor / dartc changes?

Bob: Can you look at the apidoc changes?

Stephen/Pavel: Can you guys look at the rest?

Pavel: I will update, test, and land your Dartium CL along with this change.

Committed: https://code.google.com/p/dart/source/detail?r=7587

[vsm, 2012-05-11 19:38:43]

https://chromiumcodereview.appspot.com/10389097/diff/6001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10389097/diff/6001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:252: String
host = file.getParentFile().getName();
I changed this to fix dartc lookup.  It used to map dom_deprecated to
dom_deprecated/dom.dart.  With this change, it maps to dom/dom.dart ala the
config files.

I think the "host" should be derived from the file path (as in line 226 above)
and not the library name,

https://chromiumcodereview.appspot.com/10389097/diff/6001/tests/isolate/v2_co...
File tests/isolate/v2_compute_this_script_browser_test.dart (right):

https://chromiumcodereview.appspot.com/10389097/diff/6001/tests/isolate/v2_co...
tests/isolate/v2_compute_this_script_browser_test.dart:10:
#import('dart:dom_deprecated');
I'll change this to dart:html in another CL.

[Bob Nystrom, 2012-05-11 21:25:13]

Apidoc changes LGTM!

[sra1, 2012-05-11 23:00:36]

lgtm

[Brian Wilkerson, 2012-05-11 23:23:31]

LGTM, but you might want to get Dan's input on the SystemLibraryManager change.

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibrary.java (right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibrary.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:252: String
host = file.getParentFile().getName();
I've asked Dan to take a look at this change. I'm not familiar enough with this
part of the code to know if there's anything wrong. (Although I will point out
that if this change is made we no longer need to compute the index on the line
above.)

https://chromiumcodereview.appspot.com/10389097/diff/4002/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java
(right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:2:
* Copyright 2011 Dart project authors.
nit: copyright year

[vsm, 2012-05-13 04:19:26]

Thanks, landed.

danrubel: Please let me know if you see any issues with the change to
SystemLibraryManager.java (i.e., the line Brian pointed out).

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibrary.java (right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibrary.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
On 2012/05/11 23:23:31, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/05/11 23:23:31, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10389097/diff/4002/compiler/java/com/g...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:252: String
host = file.getParentFile().getName();
Thanks for the catch on index.  Line removed.

Dan: please let me know if you see issues on this line.

On 2012/05/11 23:23:31, Brian Wilkerson wrote:
> I've asked Dan to take a look at this change. I'm not familiar enough with
this
> part of the code to know if there's anything wrong. (Although I will point out
> that if this change is made we no longer need to compute the index on the line
> above.)

https://chromiumcodereview.appspot.com/10389097/diff/4002/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java
(right):

https://chromiumcodereview.appspot.com/10389097/diff/4002/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/SystemLibraryManagerProviderTest.java:2:
* Copyright 2011 Dart project authors.
On 2012/05/11 23:23:31, Brian Wilkerson wrote:
> nit: copyright year

Done.