Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: frog/world.dart

Issue 10389097: Move dart:dom to dart:dom_deprecated (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes from review Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tests/frog_native/native_call_arity3_frog_test.dart ('k') | lib/compiler/implementation/apiimpl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/world.dart
diff --git a/frog/world.dart b/frog/world.dart
index d4550fb7ecf6dcb8a8b64f7df78e7a54ef6be5ea..ebde04beaa81a65e048a679f46fd113b584687a2 100644
--- a/frog/world.dart
+++ b/frog/world.dart
@@ -301,10 +301,11 @@ class World {
final msg = 'conflicting JS name "$name" of same '
+ 'priority $existingPri: (already defined in) '
+ '${existing.span.locationText} with priority $namedPri)';
- // We trust that conflicting native names in builtin libraries are
- // harmless. Most cases there are no conflicts, currently isolates
- // in coreimpl and dart:dom both define web workers to avoid adding a
- // dependency from corelib to dart:dom.
+ // We trust that conflicting native names in builtin libraries
+ // are harmless. Most cases there are no conflicts, currently
+ // isolates in coreimpl and dart:dom_deprecated both define
+ // web workers to avoid adding a dependency from corelib to
+ // dart:dom_deprecated.
world.info(msg, named.span, existing.span);
} else {
// Conflicting js name in same library. This happens because
@@ -471,7 +472,7 @@ class World {
libraries[filename] = library;
_todo.add(library);
- if (filename == 'dart:dom') {
+ if (filename == 'dart:dom_deprecated') {
dom = library;
} else if (filename == 'dart:html') {
html = library;
« no previous file with comments | « frog/tests/frog_native/native_call_arity3_frog_test.dart ('k') | lib/compiler/implementation/apiimpl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698