Support maximize window command.

Support maximize window command.
BUG=chromedriver:65
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142038

[kkania, 2012-05-23 17:49:20]

can you add a test to chromedriver_tests.py?

http://codereview.chromium.org/10388251/diff/1/chrome/browser/automation/test...
File chrome/browser/automation/testing_automation_provider.h (right):

http://codereview.chromium.org/10388251/diff/1/chrome/browser/automation/test...
chrome/browser/automation/testing_automation_provider.h:1103: void
MaximizeWindow(base::DictionaryValue* args, IPC::Message* reply_message);
I'd change this to MaximizeView to be consistent.

http://codereview.chromium.org/10388251/diff/1/chrome/test/automation/automat...
File chrome/test/automation/automation_json_requests.cc (right):

http://codereview.chromium.org/10388251/diff/1/chrome/test/automation/automat...
chrome/test/automation/automation_json_requests.cc:720:
dict.SetString("command", "Maximize");
This is different from what you had in testing_automation_provider.cc

http://codereview.chromium.org/10388251/diff/1/chrome/test/webdriver/webdrive...
File chrome/test/webdriver/webdriver_automation.h (right):

http://codereview.chromium.org/10388251/diff/1/chrome/test/webdriver/webdrive...
chrome/test/webdriver/webdriver_automation.h:186: void Maximize(const WebViewId&
view_id, Error** error);
MaximizeView

[kkania, 2012-05-23 17:58:42]

http://codereview.chromium.org/10388251/diff/1/chrome/test/webdriver/webdrive...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/10388251/diff/1/chrome/test/webdriver/webdrive...
chrome/test/webdriver/webdriver_automation.cc:746: automation::Error auto_error;
Also, can you return a nicer error for the user if the version of Chrome they
are using does not support this command?

[zori, 2012-05-24 00:39:32]

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/browser/automat...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/browser/automat...
chrome/browser/automation/testing_automation_provider.h:1103: void
MaximizeWindow(base::DictionaryValue* args, IPC::Message* reply_message);
On 2012/05/23 17:49:20, kkania wrote:
> I'd change this to MaximizeView to be consistent.

Done.

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/automation...
File chrome/test/automation/automation_json_requests.cc (right):

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/automation...
chrome/test/automation/automation_json_requests.cc:720:
dict.SetString("command", "Maximize");
True, that's how a unit test would have been useful.
On 2012/05/23 17:49:20, kkania wrote:
> This is different from what you had in testing_automation_provider.cc

Done.

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/webdriver/...
File chrome/test/webdriver/webdriver_automation.cc (right):

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/webdriver/...
chrome/test/webdriver/webdriver_automation.cc:746: automation::Error auto_error;
On 2012/05/23 17:58:42, kkania wrote:
> Also, can you return a nicer error for the user if the version of Chrome they
> are using does not support this command?

Done.

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/webdriver/...
File chrome/test/webdriver/webdriver_automation.h (right):

https://chromiumcodereview.appspot.com/10388251/diff/1/chrome/test/webdriver/...
chrome/test/webdriver/webdriver_automation.h:186: void Maximize(const WebViewId&
view_id, Error** error);
On 2012/05/23 17:49:20, kkania wrote:
> MaximizeView

Done.

[kkania, 2012-05-24 17:25:37]

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.cc:6521:
browser->window()->Maximize();
in thinking this over, I would prefer we go ahead and add the code for waiting
for the window to actually be maximized instead of punting it to a later CL

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.h (right):

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.h:1099: // The single
|auto_id| must be given to specify the view.
Mention it only works for tabs

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/test/webdriv...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

https://chromiumcodereview.appspot.com/10388251/diff/7001/chrome/test/webdriv...
chrome/test/webdriver/test/chromedriver_tests.py:1047:
self.assertRaises(NoSuchWindowException, self._setPosition, 1, 1,
seems like this should be in a separate test, and include maximize

[zori, 2012-05-29 23:53:32]

http://codereview.chromium.org/10388251/diff/7001/chrome/browser/automation/t...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/10388251/diff/7001/chrome/browser/automation/t...
chrome/browser/automation/testing_automation_provider.cc:6521:
browser->window()->Maximize();
On 2012/05/24 17:25:38, kkania wrote:
> in thinking this over, I would prefer we go ahead and add the code for waiting
> for the window to actually be maximized instead of punting it to a later CL

Done.

http://codereview.chromium.org/10388251/diff/7001/chrome/browser/automation/t...
File chrome/browser/automation/testing_automation_provider.h (right):

http://codereview.chromium.org/10388251/diff/7001/chrome/browser/automation/t...
chrome/browser/automation/testing_automation_provider.h:1099: // The single
|auto_id| must be given to specify the view.
On 2012/05/24 17:25:38, kkania wrote:
> Mention it only works for tabs

Done.

http://codereview.chromium.org/10388251/diff/7001/chrome/test/webdriver/test/...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/10388251/diff/7001/chrome/test/webdriver/test/...
chrome/test/webdriver/test/chromedriver_tests.py:1047:
self.assertRaises(NoSuchWindowException, self._setPosition, 1, 1,
On 2012/05/24 17:25:38, kkania wrote:
> seems like this should be in a separate test, and include maximize

Done.

[kkania, 2012-05-30 01:03:58]

Also, you need to look at src/chrome/browser/ui/views/frame/browser_view.h

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
File chrome/browser/automation/automation_provider_observers.cc (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.cc:3043: 
no newline here

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
File chrome/browser/automation/automation_provider_observers.h (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1864: IPC::Message*
reply_message);
when defining or prototyping a function, the args, if they take more than one
line, should be lined up vertically

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1867: virtual void
Observe(int type,
It's typical style to put:
// Overridden from NotificationObserver.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1869: const
content::NotificationDetails& details);
add OVERRIDE macro

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:282:
content::NotificationService::current()->Notify(
I don't think we need to use a notification here if the maximize happens
synchronously; we'll test on my mac and see if it's synchronous or not.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1621:
content::Source<GtkWindow>(window_),
instead of returning the os-specific window handle, we should return a
BrowserWindow*

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:57: // Indicates that the window has
been maximized. The source is the window
window -> BrowserWindow

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:59: NOTIFICATION_WINDOW_MAXIMIZED,
I think NOTIFICATION_BROWSER_WINDOW_MAXIMIZED would be better

[zori, 2012-05-31 23:38:22]

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
File chrome/browser/automation/automation_provider_observers.cc (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.cc:3043: 
On 2012/05/30 01:03:58, kkania wrote:
> no newline here

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
File chrome/browser/automation/automation_provider_observers.h (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1864: IPC::Message*
reply_message);
On 2012/05/30 01:03:58, kkania wrote:
> when defining or prototyping a function, the args, if they take more than one
> line, should be lined up vertically

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1867: virtual void
Observe(int type,
On 2012/05/30 01:03:58, kkania wrote:
> It's typical style to put:
> // Overridden from NotificationObserver.

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/automation/...
chrome/browser/automation/automation_provider_observers.h:1869: const
content::NotificationDetails& details);
On 2012/05/30 01:03:58, kkania wrote:
> add OVERRIDE macro

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/cocoa/br...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/cocoa/br...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:282:
content::NotificationService::current()->Notify(
On 2012/05/30 01:03:58, kkania wrote:
> I don't think we need to use a notification here if the maximize happens
> synchronously; we'll test on my mac and see if it's synchronous or not.

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1621:
content::Source<GtkWindow>(window_),
On 2012/05/30 01:03:58, kkania wrote:
> instead of returning the os-specific window handle, we should return a
> BrowserWindow*

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:57: // Indicates that the window has
been maximized. The source is the window
On 2012/05/30 01:03:58, kkania wrote:
> window -> BrowserWindow

Done.

http://codereview.chromium.org/10388251/diff/13002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:59: NOTIFICATION_WINDOW_MAXIMIZED,
On 2012/05/30 01:03:58, kkania wrote:
> I think NOTIFICATION_BROWSER_WINDOW_MAXIMIZED would be better

Done.

[kkania, 2012-06-01 04:14:03]

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1056: TaskManagerGtk::Show(false);
normally you don't sync a branch with a CL in review to avoid messing up the
diffs, but sometimes you can't help it

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1609:
content::Source<BrowserWindowGtk>(this),
Just use BrowserWindow

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:57: // Indicates that the window has
been maximized. The source is the
#if defined(OS_LINUX)

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:59: // BrowserWindowGtk), no details
are expected.
update and reword this comment

http://codereview.chromium.org/10388251/diff/17002/chrome/test/webdriver/test...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/test/webdriver/test...
chrome/test/webdriver/test/chromedriver_tests.py:1064: #
self.assertRaises(NoSuchWindowException, self._maximize, invalid_handle)
?

[Ben Goodger (Google), 2012-06-01 17:10:11]

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1606: if (event->changed_mask &
GDK_WINDOW_STATE_MAXIMIZED) {
is this already supported on other platforms?

can we avoid using notifications?

[zori, 2012-06-02 01:20:54]

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1606: if (event->changed_mask &
GDK_WINDOW_STATE_MAXIMIZED) {
On 2012/06/01 17:10:11, Ben Goodger (Google) wrote:
> is this already supported on other platforms?
> 
> can we avoid using notifications?

Since other platforms execute the maximize operation synchronously, the testing
automation provider in chrome is able to send a 'success' JSON reply right after
invoking the maximize() command on the browser window. On Linux, however, this
happens asynchronously, so we should wait for the gtk event indicating
completion of maximization. Could you, perhaps, suggest a better approach than
using the Notification Service?

http://codereview.chromium.org/10388251/diff/17002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1609:
content::Source<BrowserWindowGtk>(this),
On 2012/06/01 04:14:03, kkania wrote:
> Just use BrowserWindow

Done.

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:57: // Indicates that the window has
been maximized. The source is the
On 2012/06/01 04:14:03, kkania wrote:
> #if defined(OS_LINUX)

Done.

http://codereview.chromium.org/10388251/diff/17002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:59: // BrowserWindowGtk), no details
are expected.
On 2012/06/01 04:14:03, kkania wrote:
> update and reword this comment

Done.

http://codereview.chromium.org/10388251/diff/17002/chrome/test/webdriver/test...
File chrome/test/webdriver/test/chromedriver_tests.py (right):

http://codereview.chromium.org/10388251/diff/17002/chrome/test/webdriver/test...
chrome/test/webdriver/test/chromedriver_tests.py:1064: #
self.assertRaises(NoSuchWindowException, self._maximize, invalid_handle)
Sorry about that. Fixed.
On 2012/06/01 04:14:03, kkania wrote:
> ?

[kkania, 2012-06-04 17:47:48]

LGTM, but wait for Ben's ok.

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:58: // On Linux maximize can be
asynchronous operation. This notification
can be an asychronous

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:1083:
NOTIFICATION_PANEL_STRIP_UPDATED,
you didn't update this, right?

[zori, 2012-06-05 02:45:00]

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:58: // On Linux maximize can be
asynchronous operation. This notification
On 2012/06/04 17:47:48, kkania wrote:
> can be an asychronous

Done.

http://codereview.chromium.org/10388251/diff/29002/chrome/common/chrome_notif...
chrome/common/chrome_notification_types.h:1083:
NOTIFICATION_PANEL_STRIP_UPDATED,
On 2012/06/04 17:47:48, kkania wrote:
> you didn't update this, right?
No, I didn't, was merged from master/origin.

[Ben Goodger (Google), 2012-06-12 17:42:26]

http://codereview.chromium.org/10388251/diff/37002/chrome/browser/ui/gtk/brow...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/10388251/diff/37002/chrome/browser/ui/gtk/brow...
chrome/browser/ui/gtk/browser_window_gtk.cc:1607:
content::NotificationService::current()->Notify(
is this notification sent on other platforms already?

[zori, 2012-06-12 18:06:13]

No, it is not needed on other platforms. They execute the maximize operation
synchronously and the testing automation provider in chrome is able to send a
'success' JSON reply right after invoking the maximize() command on the browser
window. On Linux, however, this
happens asynchronously, so we should wait for the gtk event indicating
completion of maximization and send the notification.
On 2012/06/12 17:42:26, Ben Goodger (Google) wrote:
>
http://codereview.chromium.org/10388251/diff/37002/chrome/browser/ui/gtk/brow...
> File chrome/browser/ui/gtk/browser_window_gtk.cc (right):
> 
>
http://codereview.chromium.org/10388251/diff/37002/chrome/browser/ui/gtk/brow...
> chrome/browser/ui/gtk/browser_window_gtk.cc:1607:
> content::NotificationService::current()->Notify(
> is this notification sent on other platforms already?

[Ben Goodger (Google), 2012-06-13 16:24:38]

On Tue, Jun 12, 2012 at 11:06 AM, <zori@chromium.org> wrote:

> No, it is not needed on other platforms. They execute the maximize
> operation
> synchronously and the testing automation provider in chrome is able to
> send a
> 'success' JSON reply right after invoking the maximize() command on the
> browser
> window. On Linux, however, this
> happens asynchronously, so we should wait for the gtk event indicating
> completion of maximization and send the notification.


Is this also true of other window commands?

-Ben

[zori, 2012-06-13 20:10:35]

On 2012/06/13 16:24:38, Ben Goodger (Google) wrote:
> On Tue, Jun 12, 2012 at 11:06 AM, <mailto:zori@chromium.org> wrote:
> 
> > No, it is not needed on other platforms. They execute the maximize
> > operation
> > synchronously and the testing automation provider in chrome is able to
> > send a
> > 'success' JSON reply right after invoking the maximize() command on the
> > browser
> > window. On Linux, however, this
> > happens asynchronously, so we should wait for the gtk event indicating
> > completion of maximization and send the notification.
> 
> 
> Is this also true of other window commands?
> 
> -Ben

Yes, we expect similar behavior for resize, set_position (set_bounds),
fullscreen.

[Ben Goodger (Google), 2012-06-13 20:14:42]

LGTM

On Wed, Jun 13, 2012 at 1:10 PM, <zori@chromium.org> wrote:

> On 2012/06/13 16:24:38, Ben Goodger (Google) wrote:
>
>  On Tue, Jun 12, 2012 at 11:06 AM, <mailto:zori@chromium.org> wrote:
>>
>
>  > No, it is not needed on other platforms. They execute the maximize
>> > operation
>> > synchronously and the testing automation provider in chrome is able to
>> > send a
>> > 'success' JSON reply right after invoking the maximize() command on the
>> > browser
>> > window. On Linux, however, this
>> > happens asynchronously, so we should wait for the gtk event indicating
>> > completion of maximization and send the notification.
>>
>
>
>  Is this also true of other window commands?
>>
>
>  -Ben
>>
>
> Yes, we expect similar behavior for resize, set_position (set_bounds),
> fullscreen.
>
>
http://codereview.chromium.**org/10388251/<http://codereview.chromium.org/103...
>

[commit-bot: I haz the power, 2012-06-13 20:17:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zori@chromium.org/10388251/37002

[commit-bot: I haz the power, 2012-06-13 20:18:09]

Failed to apply patch for
chrome/browser/automation/automation_provider_observers.h:
While running patch -p1 --forward --force;
patching file chrome/browser/automation/automation_provider_observers.h
Hunk #1 succeeded at 106 (offset 2 lines).
Hunk #2 FAILED at 160.
Hunk #3 succeeded at 183 (offset 4 lines).
Hunk #4 succeeded at 204 (offset 4 lines).
Hunk #5 succeeded at 231 with fuzz 2 (offset 4 lines).
Hunk #6 succeeded at 256 (offset 4 lines).
Hunk #7 succeeded at 344 (offset 4 lines).
Hunk #8 succeeded at 370 (offset 4 lines).
Hunk #9 succeeded at 394 (offset 4 lines).
Hunk #10 succeeded at 421 (offset 4 lines).
Hunk #11 succeeded at 445 (offset 4 lines).
Hunk #12 succeeded at 469 (offset 4 lines).
Hunk #13 succeeded at 493 (offset 4 lines).
Hunk #14 succeeded at 516 (offset 4 lines).
Hunk #15 succeeded at 545 (offset 4 lines).
Hunk #16 succeeded at 577 (offset 4 lines).
Hunk #17 succeeded at 623 (offset 4 lines).
Hunk #18 succeeded at 644 (offset 4 lines).
Hunk #19 succeeded at 665 (offset 4 lines).
Hunk #20 succeeded at 688 (offset 4 lines).
Hunk #21 succeeded at 781 (offset 41 lines).
Hunk #22 succeeded at 1234 (offset 41 lines).
Hunk #23 succeeded at 1293 (offset 41 lines).
Hunk #24 succeeded at 1315 (offset 41 lines).
Hunk #25 succeeded at 1342 (offset 41 lines).
Hunk #26 succeeded at 1391 (offset 41 lines).
Hunk #27 succeeded at 1420 (offset 41 lines).
Hunk #28 succeeded at 1450 (offset 41 lines).
Hunk #29 succeeded at 1479 (offset 41 lines).
Hunk #30 succeeded at 1511 (offset 41 lines).
Hunk #31 succeeded at 1559 (offset 41 lines).
Hunk #32 succeeded at 1580 (offset 41 lines).
Hunk #33 succeeded at 1606 (offset 41 lines).
Hunk #34 succeeded at 1635 (offset 41 lines).
Hunk #35 succeeded at 1659 (offset 41 lines).
Hunk #36 succeeded at 1681 (offset 41 lines).
Hunk #37 succeeded at 1714 (offset 41 lines).
Hunk #38 succeeded at 1740 (offset 41 lines).
Hunk #39 succeeded at 1800 (offset 41 lines).
Hunk #40 succeeded at 1838 (offset 41 lines).
Hunk #41 succeeded at 1861 (offset 41 lines).
Hunk #42 succeeded at 1891 (offset 41 lines).
Hunk #43 succeeded at 1914 (offset 41 lines).
Hunk #44 succeeded at 1928 (offset 41 lines).
1 out of 44 hunks FAILED -- saving rejects to file
chrome/browser/automation/automation_provider_observers.h.rej

[commit-bot: I haz the power, 2012-06-13 23:07:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zori@chromium.org/10388251/52001

[commit-bot: I haz the power, 2012-06-14 00:31:33]

Change committed as 142038