Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 10388227: Revert 138216 - [Sync] Turn notifier::PushClient into an interface (Closed)

Created:
8 years, 7 months ago by akalin
Modified:
8 years, 7 months ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 138216 - [Sync] Turn notifier::PushClient into an interface Split the previous implementation into two pieces: XmppPushClient and NonBlockingPushClient. Add FakePushClient and FakePushClientObserver. Remove use of ThreadSafeObserverList. Add PushClient::CreateDefault() function, which creates a NonBlockingPushClient for an XmppPushClient. Dep-inject PushClient into P2PNotifier. Add some helper functions to notification_defines.{h,cc}. BUG=76764 TEST= Review URL: https://chromiumcodereview.appspot.com/10413014 TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -1272 lines) Patch
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M jingle/jingle.gyp View 4 chunks +2 lines, -14 lines 0 comments Download
D jingle/notifier/listener/fake_push_client.h View 1 chunk +0 lines, -55 lines 0 comments Download
D jingle/notifier/listener/fake_push_client.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D jingle/notifier/listener/fake_push_client_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D jingle/notifier/listener/fake_push_client_observer.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D jingle/notifier/listener/non_blocking_push_client.h View 1 chunk +0 lines, -70 lines 0 comments Download
D jingle/notifier/listener/non_blocking_push_client.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D jingle/notifier/listener/non_blocking_push_client_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M jingle/notifier/listener/notification_defines.h View 4 chunks +0 lines, -15 lines 0 comments Download
M jingle/notifier/listener/notification_defines.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M jingle/notifier/listener/push_client.h View 1 chunk +70 lines, -23 lines 0 comments Download
M jingle/notifier/listener/push_client.cc View 1 chunk +302 lines, -16 lines 0 comments Download
D jingle/notifier/listener/push_client_observer.h View 1 chunk +0 lines, -32 lines 0 comments Download
D jingle/notifier/listener/push_client_observer.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M jingle/notifier/listener/push_client_unittest.cc View 2 chunks +68 lines, -17 lines 0 comments Download
D jingle/notifier/listener/xmpp_push_client.h View 1 chunk +0 lines, -87 lines 0 comments Download
D jingle/notifier/listener/xmpp_push_client.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M sync/notifier/p2p_notifier.h View 4 chunks +24 lines, -13 lines 0 comments Download
M sync/notifier/p2p_notifier.cc View 5 chunks +34 lines, -22 lines 0 comments Download
M sync/notifier/p2p_notifier_unittest.cc View 8 chunks +60 lines, -88 lines 0 comments Download
M sync/notifier/sync_notifier_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
8 years, 7 months ago (2012-05-22 05:25:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698