Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: jingle/notifier/listener/xmpp_push_client_unittest.cc

Issue 10388227: Revert 138216 - [Sync] Turn notifier::PushClient into an interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « jingle/notifier/listener/xmpp_push_client.cc ('k') | sync/notifier/p2p_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: jingle/notifier/listener/xmpp_push_client_unittest.cc
===================================================================
--- jingle/notifier/listener/xmpp_push_client_unittest.cc (revision 138220)
+++ jingle/notifier/listener/xmpp_push_client_unittest.cc (working copy)
@@ -1,120 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "jingle/notifier/listener/xmpp_push_client.h"
-
-#include "base/compiler_specific.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/message_loop.h"
-#include "jingle/notifier/base/fake_base_task.h"
-#include "jingle/notifier/base/notifier_options.h"
-#include "jingle/notifier/listener/push_client_observer.h"
-#include "net/url_request/url_request_test_util.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace notifier {
-
-namespace {
-
-using ::testing::_;
-using ::testing::Mock;
-using ::testing::StrictMock;
-
-class MockObserver : public PushClientObserver {
- public:
- MOCK_METHOD1(OnNotificationStateChange, void(bool));
- MOCK_METHOD1(OnIncomingNotification, void(const Notification&));
-};
-
-class XmppPushClientTest : public testing::Test {
- protected:
- XmppPushClientTest() {
- notifier_options_.request_context_getter =
- new TestURLRequestContextGetter(message_loop_.message_loop_proxy());
- }
-
- virtual ~XmppPushClientTest() {}
-
- virtual void SetUp() OVERRIDE {
- xmpp_push_client_.reset(new XmppPushClient(notifier_options_));
- xmpp_push_client_->AddObserver(&mock_observer_);
- }
-
- virtual void TearDown() OVERRIDE {
- // Clear out any messages posted by XmppPushClient.
- message_loop_.RunAllPending();
- xmpp_push_client_->RemoveObserver(&mock_observer_);
- xmpp_push_client_.reset();
- }
-
- // The sockets created by the XMPP code expect an IO loop.
- MessageLoopForIO message_loop_;
- NotifierOptions notifier_options_;
- StrictMock<MockObserver> mock_observer_;
- scoped_ptr<XmppPushClient> xmpp_push_client_;
- FakeBaseTask fake_base_task_;
-};
-
-// Make sure the XMPP push client notifies its observers of incoming
-// notifications properly.
-TEST_F(XmppPushClientTest, OnIncomingNotification) {
- EXPECT_CALL(mock_observer_, OnIncomingNotification(_));
- xmpp_push_client_->OnNotificationReceived(Notification());
-}
-
-// Make sure the XMPP push client notifies its observers of a
-// successful connection properly.
-TEST_F(XmppPushClientTest, ConnectAndSubscribe) {
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(true));
- xmpp_push_client_->OnConnect(fake_base_task_.AsWeakPtr());
- xmpp_push_client_->OnSubscribed();
-}
-
-// Make sure the XMPP push client notifies its observers of a
-// terminated connection properly.
-TEST_F(XmppPushClientTest, Disconnect) {
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(false));
- xmpp_push_client_->OnDisconnect();
-}
-
-// Make sure the XMPP push client notifies its observers of a
-// subscription error properly.
-TEST_F(XmppPushClientTest, SubscriptionError) {
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(false));
- xmpp_push_client_->OnSubscriptionError();
-}
-
-// Make sure nothing blows up when the XMPP push client sends a
-// notification.
-//
-// TODO(akalin): Figure out how to test that the notification was
-// actually sent.
-TEST_F(XmppPushClientTest, SendNotification) {
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(true));
-
- xmpp_push_client_->OnConnect(fake_base_task_.AsWeakPtr());
- xmpp_push_client_->OnSubscribed();
- xmpp_push_client_->SendNotification(Notification());
-}
-
-// Make sure nothing blows up when the XMPP push client sends a
-// notification when disconnected, and the client connects.
-//
-// TODO(akalin): Figure out how to test that the notification was
-// actually sent.
-TEST_F(XmppPushClientTest, SendNotificationPending) {
- xmpp_push_client_->SendNotification(Notification());
-
- Mock::VerifyAndClearExpectations(&mock_observer_);
-
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(true));
-
- xmpp_push_client_->OnConnect(fake_base_task_.AsWeakPtr());
- xmpp_push_client_->OnSubscribed();
-}
-
-} // namespace
-
-} // namespace notifier
« no previous file with comments | « jingle/notifier/listener/xmpp_push_client.cc ('k') | sync/notifier/p2p_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698