Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10388207: Reverting due to memory waterfall failures. (Closed)

Created:
8 years, 7 months ago by James Hawkins
Modified:
8 years, 7 months ago
Reviewers:
mitchellwrosen
CC:
chromium-reviews, erikwright (departed), Aaron Boodman, mihaip-chromium-reviews_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Reverting due to memory waterfall failures. Revert 138044 - Allowed BinaryValue to take a NULL buffer. BUG=127630 Review URL: https://chromiumcodereview.appspot.com/10389088 TBR=mitchellwrosen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -40 lines) Patch
M base/values.h View 2 chunks +13 lines, -13 lines 0 comments Download
M base/values.cc View 2 chunks +22 lines, -14 lines 0 comments Download
M base/values_unittest.cc View 3 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Hawkins
8 years, 7 months ago (2012-05-20 02:34:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698