Reverting due to memory waterfall failures.

chrome/browser/extensions/api/socket/socket_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/socket_api.h"
 
 #include "base/bind.h"
 #include "chrome/browser/extensions/api/api_resource_controller.h"
 #include "chrome/browser/extensions/api/socket/socket.h"
 #include "chrome/browser/extensions/api/socket/tcp_socket.h"
@@ skipping 155 matching lines @@
 
 void SocketReadFunction::OnCompleted(int bytes_read,
                                      scoped_refptr<net::IOBuffer> io_buffer) {
   DictionaryValue* result = new DictionaryValue();
   result->SetInteger(kResultCodeKey, bytes_read);
   if (bytes_read > 0) {
     result->Set(kDataKey,
         base::BinaryValue::CreateWithCopiedBuffer(io_buffer->data(),
             bytes_read));
   } else {
-    result->Set(kDataKey, new base::BinaryValue());
+    // BinaryValue does not support NULL buffer. Workaround it with new char[1].
+    // http://crbug.com/127630
+    result->Set(kDataKey, base::BinaryValue::Create(new char[1], 0));
   }
   result_.reset(result);
 
   AsyncWorkCompleted();
 }
 
 SocketWriteFunction::SocketWriteFunction()
     : socket_id_(0),
       io_buffer_(NULL),
       io_buffer_size_(0) {
@@ skipping 60 matching lines @@
                                          scoped_refptr<net::IOBuffer> io_buffer,
                                          const std::string& address,
                                          int port) {
   DictionaryValue* result = new DictionaryValue();
   result->SetInteger(kResultCodeKey, bytes_read);
   if (bytes_read > 0) {
     result->Set(kDataKey,
         base::BinaryValue::CreateWithCopiedBuffer(io_buffer->data(),
             bytes_read));
   } else {
-    result->Set(kDataKey, new base::BinaryValue());
+    // BinaryValue does not support NULL buffer. Workaround it with new char[1].
+    // http://crbug.com/127630
+    result->Set(kDataKey, base::BinaryValue::Create(new char[1], 0));
   }
   result->SetString(kAddressKey, address);
   result->SetInteger(kPortKey, port);
   result_.reset(result);
 
   AsyncWorkCompleted();
 }
 
 SocketSendToFunction::SocketSendToFunction()
     : socket_id_(0),
@@ skipping 29 matching lines @@
 
 void SocketSendToFunction::OnCompleted(int bytes_written) {
   DictionaryValue* result = new DictionaryValue();
   result->SetInteger(kBytesWrittenKey, bytes_written);
   result_.reset(result);
 
   AsyncWorkCompleted();
 }
 
 }  // namespace extensions