Issue 10388169: Merge 137359 - Treat SyncCredentialsLost as an auth error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388169: Merge 137359 - Treat SyncCredentialsLost as an auth error (Closed)

Created:
8 years, 7 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1132/src/

Visibility:
Public.

More Reviews

Description

Merge 137359 - Treat SyncCredentialsLost as an auth error Break up AreCredentialsAvailable() into two routines, IsSyncEnabledAndLoggedIn() and IsSyncTokenAvailable(). ProfileSyncService now will start up the sync backend even if there's no sync token available. GetCredentials() will make up fake/invalid tokens for the sync backend to use, which will eventually yield an auth error for the user. BUG=121755 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10335015 TBR=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137484

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -67 lines)			Patch
M	chrome/browser/signin/signin_tracker.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/signin/signin_tracker_unittest.cc	View	5 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	9 chunks	+42 lines, -45 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/browser_options_handler2.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	9 chunks	+27 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages