Treat SyncCredentialsLost as an auth error

Treat SyncCredentialsLost as an auth error
Break up AreCredentialsAvailable() into two routines, IsSyncEnabledAndLoggedIn() and IsSyncTokenAvailable().
ProfileSyncService now will start up the sync backend even if there's no sync token available. GetCredentials() will make up fake/invalid tokens for the sync backend to use, which will eventually yield an auth error for the user.


BUG=121755
TEST=see bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137359

[Andrew T Wilson (Slow), 2012-05-15 23:02:53]

Nicolas, PTAL. Tim, FYI - not sure if you want to review also, since this
changes our startup criteria a bit - let me know.

[Nicolas Zea, 2012-05-15 23:39:04]

http://codereview.chromium.org/10335015/diff/1/chrome/browser/sync/profile_sy...
File chrome/browser/sync/profile_sync_service.h (right):

http://codereview.chromium.org/10335015/diff/1/chrome/browser/sync/profile_sy...
chrome/browser/sync/profile_sync_service.h:184: // Virtual to enable mocking in
tests.
Mention that being logged in does not necessarily mean tokens are available?

http://codereview.chromium.org/10335015/diff/1/chrome/browser/ui/webui/sync_s...
File chrome/browser/ui/webui/sync_setup_handler.cc (right):

http://codereview.chromium.org/10335015/diff/1/chrome/browser/ui/webui/sync_s...
chrome/browser/ui/webui/sync_setup_handler.cc:889:
!service->IsSyncTokenAvailable() ||
Do we want to check the token here? Presumably if the token isn't available, but
sync is running, then we need to wait for an auth error anyways. If we don't,
then when we succeed in logging in, we won't detect a change in connection
status and will infinite spin right?

[Andrew T Wilson (Slow), 2012-05-16 01:05:15]

jhawkins: PTAL at ui/webui

http://codereview.chromium.org/10335015/diff/1/chrome/browser/sync/profile_sy...
File chrome/browser/sync/profile_sync_service.h (right):

http://codereview.chromium.org/10335015/diff/1/chrome/browser/sync/profile_sy...
chrome/browser/sync/profile_sync_service.h:184: // Virtual to enable mocking in
tests.
On 2012/05/15 23:39:04, nzea wrote:
> Mention that being logged in does not necessarily mean tokens are available?

Done.

http://codereview.chromium.org/10335015/diff/1/chrome/browser/ui/webui/sync_s...
File chrome/browser/ui/webui/sync_setup_handler.cc (right):

http://codereview.chromium.org/10335015/diff/1/chrome/browser/ui/webui/sync_s...
chrome/browser/ui/webui/sync_setup_handler.cc:889:
!service->IsSyncTokenAvailable() ||
On 2012/05/15 23:39:04, nzea wrote:
> Do we want to check the token here? Presumably if the token isn't available,
but
> sync is running, then we need to wait for an auth error anyways. If we don't,
> then when we succeed in logging in, we won't detect a change in connection
> status and will infinite spin right?
It shouldn't matter if we check both or not (and it won't lead to infinite spin
because we no longer wait for a sync backend state transition if sync isn't
reporting an auth error).

However, it's probably safer not to check for the presence of the sync token
here just in case the user tries to bring up the settings UI before the token DB
has finished loading.

[Nicolas Zea, 2012-05-16 01:07:28]

sync LGTM

[James Hawkins, 2012-05-16 02:43:47]

lgtm

[commit-bot: I haz the power, 2012-05-16 02:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/atwilson@chromium.org/10335015/4003

[commit-bot: I haz the power, 2012-05-16 04:10:53]

Change committed as 137359